Last modified: 2013-04-27 18:11:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49722, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47722 - Make action=credits faster
Make action=credits faster
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.22.0
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on: 47723
Blocks: 47721
  Show dependency treegraph
 
Reported: 2013-04-26 10:59 UTC by Nemo
Modified: 2013-04-27 18:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2013-04-26 10:59:34 UTC
AFAIK this is what blocks bug 47721.
Comment 1 Andre Klapper 2013-04-26 11:35:45 UTC
"Make action=credits faster" is not a valid bug report, as it's unfixable (when is it "fast enough")?

Needs some actual criteria to become a bug report...
Comment 2 Nemo 2013-04-26 12:02:00 UTC
(In reply to comment #1)
> Needs some actual criteria to become a bug report...

They'll need to be added by someone who knows the requirement for enabling it on WMF wikis.
Comment 3 Sam Reed (reedy) 2013-04-26 13:49:13 UTC
mysql:wikiadmin@db1056 [enwiki]> EXPLAIN SELECT /* WikiPage::getContributors 192.168.0.18 */  rev_user AS user_id,rev_user_text AS user_name,user_real_name,MAX(rev_timestamp) AS timestamp  FROM `revision` LEFT JOIN `user` ON ((rev_user = user_id))  WHERE rev_page = '1' AND (rev_user_text != '192.168.0.18') AND ((rev_deleted & 4) = 0)  GROUP BY rev_user,rev_user_text ORDER BY timestamp DESC\G
*************************** 1. row ***************************
           id: 1
  select_type: SIMPLE
        table: revision
         type: ref
possible_keys: PRIMARY,page_timestamp,usertext_timestamp
          key: PRIMARY
      key_len: 4
          ref: const
         rows: 1
        Extra: Using where; Using temporary; Using filesort
*************************** 2. row ***************************
           id: 1
  select_type: SIMPLE
        table: user
         type: eq_ref
possible_keys: PRIMARY
          key: PRIMARY
      key_len: 4
          ref: enwiki.revision.rev_user
         rows: 1
        Extra:
2 rows in set (0.03 sec)



Main problem:
Extra: Using where; Using temporary; Using filesort
Comment 4 p858snake 2013-04-26 13:50:24 UTC
(In reply to comment #1)
>  as it's unfixable

Um, [Citation Needed]?
Comment 5 Kelson [Emmanuel Engelhart] 2013-04-27 18:11:42 UTC
@Sam Reed

IMO, this looks to be pretty complicated to achieve to build an efficient solution without computing this list asynchronously (and storing it somewhere).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links