Last modified: 2013-05-02 21:15:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49717, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47717 - VisualEditor: Link inspector input text always has LTR direction
VisualEditor: Link inspector input text always has LTR direction
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-05-13
Assigned To: Moriel Schottlender
: i18n
Depends on:
Blocks: ve-rtl
  Show dependency treegraph
 
Reported: 2013-04-26 09:54 UTC by Amir E. Aharoni
Modified: 2013-05-02 21:15 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2013-04-26 09:54:08 UTC
Steps:

1. Write some text in VisualEditor in the Hebrew Wikipedia.

2. Select a word.

3. Press the link button in the toolbar. A small link insertion panel appears.

Observed: The direction of the <input> element for the link is ltr.

Expected: The direction of the <input> element for the link is supposed to be rtl.

Comment: It does make sense to set ltr direction by default for external links (http://www.example.com). For internal links the default direction should be the same as that of that Wikipedia's content language.
Comment 1 James Forrester 2013-04-30 01:56:08 UTC
(In reply to comment #0)
> Comment: It does make sense to set ltr direction by default for external
> links (http://www.example.com). For internal links the default direction should
> be the same as that of that Wikipedia's content language.

Eurgh. That's a real mess of a user interaction - in an RTL locale, it starts as RTL, but then you type enough of a string that looks a bit like "http?://www" it magically switches to LTR? What about when your wiki page that you're internally linking to is [[http://www.amazon.com]] - do you show as LTR even though it's actually an internal link? How does this get handled in other software?
Comment 2 Amir E. Aharoni 2013-04-30 05:36:09 UTC
(In reply to comment #1)
> Eurgh. That's a real mess of a user interaction - in an RTL locale, it starts
> as RTL, but then you type enough of a string that looks a bit like
> "http?://www" it magically switches to LTR?

This is not such a mess as a matter of fact. This works very well in GMail chat, for example. If you start typing Hebrew characters, it switches the input box to RTL and vice versa. It also goes further: if you type a few Hebrew characters, and then a lot of Latin characters, it switches to LTR.

BUT -and this is very important- it is not forced: the user can switch the direction later manually. In most Windows browsers it's done using Ctrl-Shift, in Firefox on Windows and GNU/Linux it's done using Ctrl-Shift-X. I don't know about Mac browsers, but it's probably something similar. (I do know that it's impossible on Chrome in Linux, which is why I almost never use it.)

> What about when your wiki page that
> you're internally linking to is [[http://www.amazon.com]] - do you show as
> LTR
> even though it's actually an internal link? How does this get handled in
> other
> software?

Same as above, essentially. One thing that could help here would be a possibility to specify the language of the page and of the title, as in bug 34514. But that's extra icing. For a link insertion dialog it is enough to do automatic detection with a possibility to override manually.
Comment 3 James Forrester 2013-05-01 03:03:02 UTC
Moriel wants to take a stab at this one; assigning.
Comment 4 Gerrit Notification Bot 2013-05-02 07:47:46 UTC
Related URL: https://gerrit.wikimedia.org/r/61960 (Gerrit Change Ic13b9c3b155ce2979298cac9518c7419b9d45bac)
Comment 5 James Forrester 2013-05-02 21:15:20 UTC
Merged in Moriel's fix (thanks!).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links