Last modified: 2013-07-06 19:31:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49654, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 47654 - Tablesorter: colspan in buildHeaders is undefined


Summary:	Tablesorter: colspan in buildHeaders is undefined

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Derk-Jan Hartman

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	31601
	Show dependency tree / graph

Reported:	2013-04-25 16:44 UTC by Derk-Jan Hartman
Modified:	2013-07-06 19:31 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2013-04-25 16:44:08 UTC

There is a reference to this.colspan there, but it should be this.colSpan and it causes the used colspan to always be 1. This might have some effect on the format detection or something, but I couldn't readily find a testcase that would illustrate that this error has any effect. Requires further investigation.

Comment 1 Andre Klapper 2013-04-26 09:05:45 UTC

Is there a testcase where to see this?

Comment 2 Derk-Jan Hartman 2013-04-26 09:14:35 UTC

"I couldn't readily find a testcase that would illustrate that this error has any effect."

So no. I just noticed it when I copied that code and rewrote it for rowspan only to figure out that the code block wasn't working. I tried finding what would be broken due to this, but was not able to find an issue yet. (possibly the whole block isn't even required ?)

Comment 3 Derk-Jan Hartman 2013-07-06 15:03:59 UTC

I have rewritten this part of the code in https://gerrit.wikimedia.org/r/71530

Comment 4 Gerrit Notification Bot 2013-07-06 15:04:18 UTC

Change 71530 had a related patch set uploaded by TheDJ:
Tablesorter: colSpan property was incorrectly accessed

https://gerrit.wikimedia.org/r/71530

Comment 5 Gerrit Notification Bot 2013-07-06 19:31:44 UTC

Change 71530 merged by jenkins-bot:
Tablesorter: colSpan property was incorrectly accessed

https://gerrit.wikimedia.org/r/71530

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links