Last modified: 2014-04-16 13:13:28 UTC
Bugzilla gerrit bot should mention patch author when notifying about a new changeset. Example bot post: Related URL: https://gerrit.wikimedia.org/r/60705 (Gerrit Change I3517a9aab8fa8935a86130c4bbdc0ce117f28f02) (From bug 45979 comment 7.)
Any progress on this?
I am not sure how much content of the gerrit discussion we should bring over to bugzilla. We already had several requests to have gerrit add less comments, or make the comments even denser. So I would rather not pack more information into the comments added by gerrit's bugzilla plugin. Besides, would it make a difference for the change to see /who/ uploaded it? I hope the answer is „no”, and a change would undergoes the same review process regardless of whether Tim, Chad, or my mother uploaded it. But what do others think? Would adding the author make sense? If so, only the author or also the committer? Should we add further notices if follo-wup patch sets on the same change come from a different author/committer? That'd get crowded really quick :-/ But I'd rather leave it as it is now.
(In reply to comment #2) > Besides, would it make a difference for the change to see /who/ > uploaded it? I hope the answer is „no”, and a change would undergoes > the same review process regardless of whether Tim, Chad, or my mother > uploaded it. Well, we do set the assignees sometimes. So it does matter who is working on a bug, and it'd be nice if this could be visible without actually going to gerrit. > If so, only the author or also the committer? This would usually be the same person. I think the most appropriate would be the changeset "owner" on gerrit (that is, as far as I understand it, committer of the first patchset).
Looking at bug 23942 comment 13 this seems fixed. Thanks guys.
Hmm, it's using patch's committer, not patch's author nor patchset owner. I'd say this is suboptimal (for example: the bot posts notification with me as the author when I link a bug in somebody else's commit's message).
Ah, whatever. It's good enough.
