Last modified: 2013-05-15 17:26:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49581, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47581 - VisualEditor: API paction=serialize should say so if Parsoid is unavailable (instead of status "success" with missing content)
VisualEditor: API paction=serialize should say so if Parsoid is unavailable (...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-05-27
Assigned To: Ed Sanders
:
Depends on:
Blocks: 48426
  Show dependency treegraph
 
Reported: 2013-04-23 22:51 UTC by Krinkle
Modified: 2013-05-15 17:26 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-04-23 22:51:45 UTC
1. Parsoid not running, VisualEditor enabled on to-be-created page X
2. Enter a few words 
3. "Review and Save"
4. Loader keeps spinning indefinitely

Request:

action=visualeditor&paction=serialize&html=%3Cp+data-ve-changed%3D%22%7B%26quot%3Bcontent%26quot%3B%3A7%7D%22%3Edfgdg%3C%2Fp%3E&page=Sandbox%2F1&oldid=0&token=%2B%5C&format=json

Response:

{"visualeditor":{"result":"success","content":false}}

No errors.

Note this bug could also be reported as "Loader keeps spinning forever when creating a new page and trying to review/save it"
Comment 1 Gerrit Notification Bot 2013-04-24 00:02:00 UTC
Related URL: https://gerrit.wikimedia.org/r/60613 (Gerrit Change Icdf64a792c13a326f494e051be47f2946928d142)
Comment 2 Krinkle 2013-04-24 00:21:08 UTC
(In reply to comment #1)
> Related URL: https://gerrit.wikimedia.org/r/60613 (Gerrit Change
> Icdf64a792c13a326f494e051be47f2946928d142)

This fixed the visible problem described below:

(In reply to comment #0)
> as "Loader keeps spinning forever when creating a new page and
> trying to review/save it"

The error is now handled by stopping the spinner (as we always do after an aborted load) and display the error.

The error message in my case was "No Wikitext content in response from server" triggered from ve.init.mw.Target.onSerialize's patch where there are no errors and eventually finds this by type-checking the content property.

Lowering priority. Todo tasks:

* Don't return status "success" if content is missing, but use status "error".

* Make it not just status "error" but actually trigger a proper API response.error property with a more direct error, namely that the Parsoid server is unavailable.
Comment 3 Gerrit Notification Bot 2013-05-15 15:30:35 UTC
Related URL: https://gerrit.wikimedia.org/r/63861 (Gerrit Change I6bdd177bc9b5a0af9107cf08d8e46470c6778e12)
Comment 4 James Forrester 2013-05-15 17:26:53 UTC
Merged into master; will go out with wmf5.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links