Last modified: 2013-07-25 07:04:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 47482 - RedisCategorySync doesn't work due to core change
RedisCategorySync doesn't work due to core change
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
All All
: High normal (vote)
: ---
Assigned To: Ori Livneh
Depends on:
Blocks: wmf-deployment
  Show dependency treegraph
Reported: 2013-04-21 21:16 UTC by Matthew Flaschen
Modified: 2013-07-25 07:04 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Matthew Flaschen 2013-04-21 21:16:27 UTC
Since c3e39d2b6d5f6895389bd9acb38c4dfa6b243890 in core, RedisCategorySync does not work because the category updates (onCategoryAfterPageAdded/onCategoryAfterPageRemoved) (can) run *after* onLinksUpdateComplete.  The change was to improve performance by moving updateCategoryCounts to the end of the transaction.

I see two options:

1. No longer batch the adds and removes.  This may not be okay if Redis is fast enough.
2. Find another hook for batching that is guaranteed to be late enough.  There isn't an obvious good choice here, but I looked briefly.
Comment 1 Matthew Flaschen 2013-04-21 21:21:03 UTC
Sorry, I meant "This may be okay if Redis is fast enough".
Comment 2 Ori Livneh 2013-04-21 21:30:36 UTC
Good catch and good report. I'll only have time to look at this tomorrow, which I'll do unless you beat me to it. In the meantime, I'll do a single manual refresh of the categories to ensure they are not wildly out-of-sync with the database.
Comment 3 Steven Walling 2013-04-21 21:49:13 UTC
Just to confirm: after checking out Special:GettingStarted live on the site and refresh a dozen+ times, I'm not seeing any major regression in terms of missing or repeated list items (yet).
Comment 4 Ori Livneh 2013-04-21 23:31:47 UTC
I manually synchronized a little over an hour ago, at 22:05 UTC.
Comment 5 Gerrit Notification Bot 2013-04-22 00:59:46 UTC
Related URL: (Gerrit Change Ib073661c267cbabbe2ab2245224afd12b8784fca)
Comment 6 Matthew Flaschen 2013-04-22 02:48:50 UTC
Steven, the core change is not deployed to any WMF sites yet (not even in a deployment branch).  So we have some time to fix it.
Comment 7 Ori Livneh 2013-04-22 02:50:28 UTC
(In reply to comment #6)
> Steven, the core change is not deployed to any WMF sites yet (not even in a
> deployment branch).  So we have some time to fix it.

Gah. The bug title could have made that more explicit.
Comment 8 Aaron Schulz 2013-04-22 02:51:59 UTC
The change is on 1.22wmf2 sites, though not wmf1 sites.
Comment 9 Steven Walling 2013-04-22 02:57:01 UTC
(In reply to comment #8)
> The change is on 1.22wmf2 sites, though not wmf1 sites.

Which means it will be on enwiki tomorrow after the 11AM-1PM deploy, which is where RedisCategorySync is being exposed to users.
Comment 10 Gerrit Notification Bot 2013-04-22 21:30:10 UTC (Gerrit Change Ib073661c267cbabbe2ab2245224afd12b8784fca) | change APPROVED and MERGED [by jenkins-bot]

Note You need to log in before you can comment on or make changes to this bug.