Last modified: 2013-07-04 10:34:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49403, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47403 - Parsoid: Extra new line in wikitext causes <br> that makes parent <p> typeof="mw:Placeholder"
Parsoid: Extra new line in wikitext causes <br> that makes parent <p> typeof=...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
PC Windows 7
: High trivial
: ---
Assigned To: Gabriel Wicke
http://en.wikipedia.org/wiki/Generali...
: easy
Depends on:
Blocks: 49623
  Show dependency treegraph
 
Reported: 2013-04-19 11:41 UTC by dayuloli
Modified: 2013-07-04 10:34 UTC (History)
7 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Unable to edit (169.16 KB, image/jpeg)
2013-04-19 11:41 UTC, dayuloli
Details

Description dayuloli 2013-04-19 11:41:41 UTC
Created attachment 12144 [details]
Unable to edit

Unable to edit the last paragraph of this article. Unable to reproduce this with other articles. Consistent across Google Chrome and Mozilla Aurora.
Comment 1 James Forrester 2013-04-19 18:02:12 UTC
This appears to result from Parsoid giving:

<p typeof="mw:Placeholder" data-parsoid="…"><br data-parsoid="…">
Generalization has been shown to be refined and/or stabilized after sleep.<span id="cite_ref-2-0" class="reference" about="#mwt5" typeof="mw:Object/Ext/Ref" data-parsoid="…"><a href="#cite_note-2" data-parsoid="{}">[2]</a></span></p>

The typeof="mw:Placeholder" presumably comes from the extra new line between the paragraphs creating a <br>? Is this intended behaviour that VE should adjust for?
Comment 2 Gabriel Wicke 2013-04-19 18:06:23 UTC
We are protecting the p/br paragraphs as the VE did not support them well so far. The mw:Placeholder type alienates the paragraph in VE.

If the VE supports empty p/br paragraphs now we can easily remove the protection, which will make the paragraph editable in VE.
Comment 3 Gabriel Wicke 2013-05-01 21:47:16 UTC
Please reopen when the VE wants the protection to be removed.
Comment 4 James Forrester 2013-06-17 03:00:52 UTC
I think we want this removed; will check with Roan tomorrow for a final comment.
Comment 5 James Forrester 2013-06-17 18:12:54 UTC
Confirmed that we want this removed.
Comment 6 Gerrit Notification Bot 2013-06-17 18:39:55 UTC
Related URL: https://gerrit.wikimedia.org/r/69138 (Gerrit Change I932e4b41de7b665d4c7bb53caf2284c95c794bfe)
Comment 7 Gerrit Notification Bot 2013-06-17 18:43:20 UTC
https://gerrit.wikimedia.org/r/69138 (Gerrit Change I932e4b41de7b665d4c7bb53caf2284c95c794bfe) | change APPROVED and MERGED [by jenkins-bot]
Comment 8 Andre Klapper 2013-07-04 10:34:33 UTC
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links