Last modified: 2014-06-21 14:27:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49161, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 47161 - UploadWizard fails badly with jshint
UploadWizard fails badly with jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Mark Holmquist
:
: 61642 (view as bug list)
Depends on:
Blocks: 49987 jshint
  Show dependency tree / graph
 
Reported: 2013-04-12 09:03 UTC by Yuvi Panda
Modified: 2014-06-21 14:27 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Comment 1 Alex Monk 2013-04-13 23:05:13 UTC 
https://github.com/wikimedia/mediawiki-extensions-UploadWizard/pull/1

(Yuvi is going to use this to test his new GH->Gerrit system)
Comment 2 Gerrit Notification Bot 2013-04-13 23:19:42 UTC 
Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)
Comment 3 Gerrit Notification Bot 2013-04-13 23:19:44 UTC 
Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)
Comment 4 Gerrit Notification Bot 2013-04-13 23:19:46 UTC 
Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)
Comment 5 Gerrit Notification Bot 2013-04-13 23:19:49 UTC 
Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)
Comment 6 Gerrit Notification Bot 2013-04-13 23:19:51 UTC 
Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)
Comment 7 Gerrit Notification Bot 2013-04-13 23:19:53 UTC 
Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)
Comment 8 Gerrit Notification Bot 2013-04-13 23:19:55 UTC 
Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)
Comment 9 Yuvi Panda 2013-04-13 23:44:13 UTC 
Don't merge yet, this shall be nice testing grounds for https://github.com/yuvipanda/SuchABot :)
Comment 10 Gerrit Notification Bot 2013-04-15 05:52:06 UTC 
Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)
Comment 11 Gerrit Notification Bot 2013-04-15 05:52:09 UTC 
Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)
Comment 12 Gerrit Notification Bot 2013-04-15 05:52:11 UTC 
Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)
Comment 13 Gerrit Notification Bot 2013-04-15 05:52:13 UTC 
Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)
Comment 14 Gerrit Notification Bot 2013-04-15 05:52:15 UTC 
Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)
Comment 15 Gerrit Notification Bot 2013-04-15 05:52:17 UTC 
Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)
Comment 16 Gerrit Notification Bot 2013-04-15 05:52:20 UTC 
Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)
Comment 17 Gerrit Notification Bot 2013-04-15 06:55:19 UTC 
Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)
Comment 18 Gerrit Notification Bot 2013-04-15 06:55:21 UTC 
Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)
Comment 19 Gerrit Notification Bot 2013-04-15 06:55:23 UTC 
Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)
Comment 20 Gerrit Notification Bot 2013-04-15 06:55:25 UTC 
Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)
Comment 21 Gerrit Notification Bot 2013-04-15 06:55:28 UTC 
Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)
Comment 22 Gerrit Notification Bot 2013-04-15 06:55:30 UTC 
Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)
Comment 23 Gerrit Notification Bot 2013-04-15 06:55:32 UTC 
Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)
Comment 24 Mark Holmquist 2013-08-15 20:51:19 UTC 
It looks like there's still significant amounts of work to do on this - should I leave you assigned, Krenair, or do you want to pass this on to the crowd?
Comment 25 Mark Holmquist 2013-08-21 18:34:06 UTC 
Tooo late. I started a big ol' patch to fix things. I may split it up later if asked nicely.
Comment 26 Alex Monk 2013-08-21 20:35:24 UTC 
Sorry, I kept meaning to reply to this but never got around to it. Please 'pass this on to the crowd' :)
Comment 27 Gerrit Notification Bot 2013-08-23 00:56:04 UTC 
Change 80523 had a related patch set uploaded by MarkTraceur:
Loads of work on jshint fixes

https://gerrit.wikimedia.org/r/80523
Comment 28 Gerrit Notification Bot 2013-08-26 00:16:02 UTC 
Change 80945 had a related patch set uploaded by MarkTraceur:
More jshint fixes

https://gerrit.wikimedia.org/r/80945
Comment 29 Gerrit Notification Bot 2013-08-26 01:20:51 UTC 
Change 80947 had a related patch set uploaded by MarkTraceur:
Further jshint fixes

https://gerrit.wikimedia.org/r/80947
Comment 30 Gerrit Notification Bot 2013-08-27 00:34:45 UTC 
Change 80523 merged by jenkins-bot:
Loads of work on jshint fixes

https://gerrit.wikimedia.org/r/80523
Comment 31 Mark Holmquist 2013-08-27 20:40:34 UTC 
Once the patches in gerrit are merged, we can mark this bug as fixed and make the jshint job voting in Jenkins. Exciting!
Comment 32 Gerrit Notification Bot 2013-10-01 00:00:22 UTC 
Change 80954 had a related patch set uploaded by MarkTraceur:
Further jshint fixes

https://gerrit.wikimedia.org/r/80954
Comment 33 Gerrit Notification Bot 2013-10-01 00:07:18 UTC 
Change 86776 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.ConfirmCloseWindow.js

https://gerrit.wikimedia.org/r/86776
Comment 34 Gerrit Notification Bot 2013-10-01 00:07:56 UTC 
Change 86777 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/86777
Comment 35 Gerrit Notification Bot 2013-10-01 00:08:22 UTC 
Change 86778 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardDescription.js

https://gerrit.wikimedia.org/r/86778
Comment 36 Gerrit Notification Bot 2013-10-01 00:10:07 UTC 
Change 86779 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardDetails.js

https://gerrit.wikimedia.org/r/86779
Comment 37 Gerrit Notification Bot 2013-10-01 00:11:07 UTC 
Change 80945 abandoned by MarkTraceur:
More jshint fixes

Reason:
Split into:
* If3023606e187afd3ac49739de7545f4fd3ba60f4
* I66a32316613a0779a7ca3a5b77698cacca1ba11f
* Iafb382ca73652b254e097dce7521eee6a783a504
* If7e2ab0fc347841ead3073bc63ba85b4a96795ab

https://gerrit.wikimedia.org/r/80945
Comment 38 Gerrit Notification Bot 2013-10-01 01:16:49 UTC 
Change 86789 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/86789
Comment 39 Gerrit Notification Bot 2013-10-01 01:17:46 UTC 
Change 86787 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/86787
Comment 40 Gerrit Notification Bot 2013-10-01 01:18:55 UTC 
Change 80947 abandoned by MarkTraceur:
Further jshint fixes

Reason:
Split into:
* I3552fcb0ccd4902c3cd02f2c6eb133b752e3d1ff
* I1c54a2c2f82dcddf8bdfa63ff80b320744aa6b2f

https://gerrit.wikimedia.org/r/80947
Comment 41 Gerrit Notification Bot 2013-10-01 01:26:05 UTC 
Change 86791 had a related patch set uploaded by MarkTraceur:
Ignore unused jasmine tests for jshint

https://gerrit.wikimedia.org/r/86791
Comment 42 Gerrit Notification Bot 2013-10-01 01:26:32 UTC 
Change 86792 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardPage.js

https://gerrit.wikimedia.org/r/86792
Comment 43 Gerrit Notification Bot 2013-10-01 01:27:01 UTC 
Change 86793 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardUploadInterface.js

https://gerrit.wikimedia.org/r/86793
Comment 44 Gerrit Notification Bot 2013-10-01 01:27:20 UTC 
Change 86794 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardUtil.js

https://gerrit.wikimedia.org/r/86794
Comment 45 Gerrit Notification Bot 2013-10-01 01:27:41 UTC 
Change 86797 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UtilitiesTime.js

https://gerrit.wikimedia.org/r/86797
Comment 46 Gerrit Notification Bot 2013-10-01 01:28:25 UTC 
Change 86798 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.fileApi.js

https://gerrit.wikimedia.org/r/86798
Comment 47 Gerrit Notification Bot 2013-10-01 02:28:45 UTC 
Change 80954 merged by jenkins-bot:
Further jshint fixes

https://gerrit.wikimedia.org/r/80954
Comment 48 Gerrit Notification Bot 2013-10-01 02:30:57 UTC 
Change 86793 abandoned by MarkTraceur:
jshint fixes for mw.UploadWizardUploadInterface.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86793
Comment 49 Gerrit Notification Bot 2013-10-01 02:31:05 UTC 
Change 86794 abandoned by MarkTraceur:
jshint fixes for mw.UploadWizardUtil.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86794
Comment 50 Gerrit Notification Bot 2013-10-01 02:31:10 UTC 
Change 86797 abandoned by MarkTraceur:
jshint fixes for mw.UtilitiesTime.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86797
Comment 51 Gerrit Notification Bot 2013-10-01 02:31:14 UTC 
Change 86798 abandoned by MarkTraceur:
jshint fixes for mw.fileApi.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86798
Comment 52 Gerrit Notification Bot 2013-10-01 02:31:17 UTC 
Change 86792 abandoned by MarkTraceur:
jshint fixes for mw.UploadWizardPage.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86792
Comment 53 Gerrit Notification Bot 2013-10-01 02:31:44 UTC 
Change 86791 abandoned by MarkTraceur:
Ignore unused jasmine tests for jshint

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86791
Comment 54 Mark Holmquist 2013-10-01 03:20:23 UTC 
Sorry about all of the notifications - might have been smart to have split this into multiple bugs...ah well, too late to turn back now!
Comment 55 Gerrit Notification Bot 2013-10-06 23:51:20 UTC 
Change 86776 merged by jenkins-bot:
jshint fixes for mw.ConfirmCloseWindow.js

https://gerrit.wikimedia.org/r/86776
Comment 56 Gerrit Notification Bot 2013-10-06 23:55:16 UTC 
Change 86778 merged by jenkins-bot:
jshint fixes for mw.UploadWizardDescription.js

https://gerrit.wikimedia.org/r/86778
Comment 57 Andre Klapper 2014-02-17 19:23:47 UTC 
Ignoring MERGED and ABANDONED patchsets in Gerrit, this is what is left here:
https://gerrit.wikimedia.org/r/#/c/86777/
https://gerrit.wikimedia.org/r/#/c/86779/
https://gerrit.wikimedia.org/r/#/c/86789/
https://gerrit.wikimedia.org/r/#/c/86787/
Comment 58 Mark Holmquist 2014-03-25 00:35:30 UTC 
*** Bug 61642 has been marked as a duplicate of this bug. ***
Comment 59 Gerrit Notification Bot 2014-05-02 08:41:51 UTC 
Change 86787 merged by jenkins-bot:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/86787
Comment 60 Gerrit Notification Bot 2014-05-06 11:56:38 UTC 
Change 86789 merged by jenkins-bot:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/86789
Comment 61 Gerrit Notification Bot 2014-05-06 12:02:16 UTC 
Change 86779 merged by jenkins-bot:
jshint fixes for mw.UploadWizardDetails.js

https://gerrit.wikimedia.org/r/86779
Comment 62 Gerrit Notification Bot 2014-05-06 12:12:04 UTC 
Change 131685 had a related patch set uploaded by Gilles:
Fix missed jshint issues

https://gerrit.wikimedia.org/r/131685
Comment 63 Gerrit Notification Bot 2014-05-06 12:14:57 UTC 
Change 131685 merged by jenkins-bot:
Fix missed jshint issues

https://gerrit.wikimedia.org/r/131685
Comment 64 Gerrit Notification Bot 2014-05-06 12:21:10 UTC 
Change 131686 had a related patch set uploaded by Gilles:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/131686
Comment 65 Gerrit Notification Bot 2014-05-07 12:47:20 UTC 
Change 131686 merged by jenkins-bot:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/131686
Comment 66 Mark Holmquist 2014-05-19 17:54:38 UTC 
Poke (for Yuvi)
Comment 67 Mark Holmquist 2014-05-19 17:58:58 UTC 
Sigh yuvi, poking again
Comment 68 Mark Holmquist 2014-05-19 18:01:10 UTC 
Stop failing yuvi
Comment 69 Gerrit Notification Bot 2014-05-20 07:04:01 UTC 
Change 86777 merged by jenkins-bot:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/86777
Comment 70 Antoine "hashar" Musso (WMF) 2014-05-20 13:24:15 UTC 
So apparently UploadWizard pass the Jenkins job jslint which runs JSHint.  Should we consider this bug fixed and make the job voting? :-)
Comment 71 Gerrit Notification Bot 2014-05-22 08:25:42 UTC 
Change 134791 had a related patch set uploaded by Gilles:
Make jslint voting for UploadWizard

https://gerrit.wikimedia.org/r/134791
Comment 72 Gerrit Notification Bot 2014-05-22 08:26:50 UTC 
Change 134791 merged by jenkins-bot:
Make jslint voting for UploadWizard

https://gerrit.wikimedia.org/r/134791
Comment 73 Antoine "hashar" Musso (WMF) 2014-05-22 08:34:14 UTC 
There is nothing left to do now :-) Congratulations!
Comment 74 Alex Monk 2014-05-22 10:50:39 UTC 
Yay.
Comment 75 Tomasz W. Kozlowski 2014-05-22 21:46:08 UTC 
Amazing job everyone! Woo-hoo!
Comment 76 Gerrit Notification Bot 2014-06-21 12:15:00 UTC 
Change 141190 had a related patch set uploaded by Inchikutty:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/141190
Comment 77 Gerrit Notification Bot 2014-06-21 12:15:11 UTC 
Change 141195 had a related patch set uploaded by Inchikutty:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/141195
Comment 78 Gerrit Notification Bot 2014-06-21 12:15:22 UTC 
Change 141198 had a related patch set uploaded by Inchikutty:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/141198
Comment 79 Gerrit Notification Bot 2014-06-21 12:15:44 UTC 
Change 141209 had a related patch set uploaded by Inchikutty:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/141209
Comment 80 Gerrit Notification Bot 2014-06-21 14:19:56 UTC 
Change 141209 abandoned by Alex Monk:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/141209
Comment 81 Gerrit Notification Bot 2014-06-21 14:20:17 UTC 
Change 141198 abandoned by Alex Monk:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/141198
Comment 82 Gerrit Notification Bot 2014-06-21 14:22:09 UTC 
Change 141195 abandoned by Alex Monk:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/141195
Comment 83 Gerrit Notification Bot 2014-06-21 14:22:18 UTC 
Change 141190 abandoned by Alex Monk:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/141190
Comment 84 Alex Monk 2014-06-21 14:27:48 UTC 
(Someone reuploaded every change since what appeared to be the 26th of Febuary. I have cleaned them up.)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links