Last modified: 2013-10-25 14:30:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48893, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46893 - Remove page-object gem deprecation warnings
Remove page-object gem deprecation warnings
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Željko Filipin
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-04 14:21 UTC by Željko Filipin
Modified: 2013-10-25 14:30 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Željko Filipin 2013-04-04 14:21:15 UTC
This will cause page-object gem deprecation warning:

$ bundle exec cucumber features/page.feature:44
Using the default profile...
..*** DEPRECATION WARNING
*** You are calling a method named a at /Users/z/project/wmf/browsertests/features/support/pages/article_page.rb:18:in `block in <class:ArticlePage>'.
*** This method does not exist in page-object so it is being passed to the driver.
*** This feature will be removed in the near future.
*** Please change your code to call the correct page-object method.
*** If you are using functionality that does not exist in page-object please request it be added.
......

1 scenario (1 passed)
8 steps (8 passed)
0m22.284s



Example in Jenkins:

https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/92/console



There are four deprecation warnings in the entire test run:

https://wmf.ci.cloudbees.com/job/browsertests-linux-chrome/258/console



Fix the code so the warnings no longer appear.
Comment 1 Željko Filipin 2013-05-10 11:00:29 UTC
Make sure to fix deprecation warning in both qa/browsertests and mediawiki/extensions/MobileFrontend
Comment 2 Tomislav Plavcic 2013-07-18 23:21:46 UTC
Question: for MobileFrontend there is only one line that should be updated and that is in file:
tests/acceptance/features/support/pages/search_page.rb
line: page.search_results_element.a
should be: page.search_results_element.element.a

Should I make a commit just for this or somebody else will update it when doing some bigger commit?
Comment 3 Željko Filipin 2013-07-23 09:56:25 UTC
Implemented for qa/browsertests in https://gerrit.wikimedia.org/r/#/c/74091/
Comment 4 Željko Filipin 2013-07-23 09:57:19 UTC
Tomislav, please make the commit.
Comment 5 Gerrit Notification Bot 2013-07-25 00:07:08 UTC
Change 75818 had a related patch set uploaded by Plavi:
QA: Remove page-object gem deprecation warnings

https://gerrit.wikimedia.org/r/75818
Comment 6 Gerrit Notification Bot 2013-07-25 01:08:33 UTC
Change 75818 merged by jenkins-bot:
QA: Remove page-object gem deprecation warnings

https://gerrit.wikimedia.org/r/75818
Comment 7 Tomislav Plavcic 2013-10-24 19:55:57 UTC
I think this bug can be closed because all of the initial problems were fixed here: https://gerrit.wikimedia.org/r/#/c/74091/ 
and here: https://gerrit.wikimedia.org/r/75818

I know there's another similar bug (54590) for VE but that's going to be closed there...
Comment 8 Chris McMahon 2013-10-24 20:00:57 UTC
Jeff fixed a couple for us just now:  https://github.com/cheezy/page-object/issues/192

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links