Last modified: 2014-05-06 23:34:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46779 - Provide a way to persistently disable CodeEditor (no cookie --> hidden user preference)
Provide a way to persistently disable CodeEditor (no cookie --> hidden user p...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeEditor (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: 55936
  Show dependency treegraph
 
Reported: 2013-04-02 09:25 UTC by Michael M.
Modified: 2014-05-06 23:34 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael M. 2013-04-02 09:25:36 UTC
Every editor can be disabled in preferences, but not CodeEditor. On Wikipedia it just loads on every Module: page, and even ignores the settings about WikiEditor (it loads WikiEditor even if disabled and hooks into it).
Comment 1 MZMcBride 2013-09-03 18:49:36 UTC
Is the toolbar toggle button insufficient? It should be persistent.

I'm extremely wary of adding yet another user preference, though I agree that the overall inconsistency of where/how user preferences are set is troublesome.
Comment 2 Michael M. 2013-09-04 08:26:44 UTC
As the toggle button status is stored in a cookie it is not persistent for users regularily switching browsers, or clearing their cookies, etc.

Users who disabled WikiEditor will get it loaded even if CodeEditor is toggled off, which might be a problem for users with slow/expensive internet connection, slow browsers, etc.
Comment 3 Derk-Jan Hartman 2013-09-04 10:02:31 UTC
Eh, i don't want to see this in the prefs as a plain user, but we could hide the pref, and use the toolbar button to toggle it using the api perhaps ?

Nice to have, patches welcome :D
Comment 4 MZMcBride 2013-09-04 15:34:56 UTC
(In reply to comment #3)
> Eh, i don't want to see this in the prefs as a plain user, but we could hide
> the pref, and use the toolbar button to toggle it using the api perhaps ?

Yup.
Comment 5 MZMcBride 2014-01-30 16:59:55 UTC
Based on discussion on this bug report, I tried to clarify the bug summary. I don't think adding a hidden user preference will be very difficult, so I've marked this bug report with the "easy" keyword accordingly.
Comment 6 Derk-Jan Hartman 2014-04-28 10:07:45 UTC
I think it should also observe the WikiEditor preference, to make sure it doesn't load for people who have disabled that. In my opinion, those should be somewhat separate decisions but that might be troublesome in the short run.
Comment 7 Waldir 2014-04-28 10:32:49 UTC
Additional discussion occurring here: https://www.mediawiki.org/wiki/Thread:Extension_talk:CodeEditor/How_to_disable%3F
Comment 8 Gerrit Notification Bot 2014-04-28 13:37:26 UTC
Change 130068 had a related patch set uploaded by TheDJ:
Persistent disabling of CodeEditor

https://gerrit.wikimedia.org/r/130068
Comment 9 Gerrit Notification Bot 2014-05-06 17:39:35 UTC
Change 130068 merged by jenkins-bot:
Persistent disabling of CodeEditor

https://gerrit.wikimedia.org/r/130068

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links