Last modified: 2013-06-05 18:15:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48658, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46658 - Tpl-style encapsulation for <*include*> and lang-variant conversions
Tpl-style encapsulation for <*include*> and lang-variant conversions
Status: RESOLVED INVALID
Product: Parsoid
Classification: Unclassified
token-stream transforms (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: 41716
  Show dependency tree / graph
 
Reported: 2013-03-28 21:43 UTC by ssastry
Modified: 2013-06-05 18:15 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description ssastry 2013-03-28 21:43:34 UTC 
Parsoid should encapsulate content generated from <*include*> tags and from lang-variant conversion tags so that it can be correctly serialized on save.

We should use a technique similar to encapsulation of template and extension generated content.  In the best case, it might be possible to piggyback on top of existing code by assigning the right mw:Object/* types which will automatically encapsulate such content, or generalize the typeof tests to cover the new scenarios.
Comment 1 Gabriel Wicke 2013-05-21 22:22:38 UTC 
We are round-tripping noinclude / includeonly / onlyinclude tags quite well. Please explain the issues you see here.

Language variants will need some thought and serious refactoring in the LanguageConverter to wean it off mutable page-global state. The best solution is probably to treat language conversion similar to an extension or a DOM-based template. I don't think that there is a need to support unbalanced variant output, so figuring out the DOM range for encapsulation should not actually be needed.
Comment 2 ssastry 2013-06-05 18:15:51 UTC 
Just a stale ticket.  We dont support language variants yet.  We can worry about the details when we get to it.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links