Last modified: 2013-08-28 19:33:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48486, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46486 - [Regression] Vector: Variant dropdown no longer triggered on click or focus
[Regression] Vector: Variant dropdown no longer triggered on click or focus
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.21.x
All All
: Normal minor (vote)
: ---
Assigned To: Krinkle
: accessibility, code-update-regression, easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-23 13:10 UTC by Liangent
Modified: 2013-08-28 19:33 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2013-03-23 13:10:20 UTC 
It seems the solution of bug 24298 also need to be applied to this downdrop list.
Comment 1 Liangent 2013-03-23 13:14:24 UTC 
s/downdrop/dropdown/ in comment 0. :)
Comment 2 Krinkle 2013-04-13 04:18:08 UTC 
Tagging 'easy'. Just re-use the implementation for p-cactions.
Comment 3 Krinkle 2013-04-13 05:58:01 UTC 
r86861 (the fix for bug 24298) was followed-up by r99083 which made the feature more generic by applying it to any vectorMenu (instead of just p-cactions).

If this is not working on the language variants menu, perhaps it doesn't have the "vectorMenu" menu class. This would presumably cause other problems as well.

Checking SkinVector.php I see both p-varians and p-cations have class "vectorMenu" set. So it should be working.

It isn't working because I9a2ebd503e change the current-variant heading and the dropdown arrow heading (h4 and h5 respectively) to h3. And the script looks for the first h3 in a vectorMenu, which as of I9a2ebd503e is no longer the heading with the trigger in it.
Comment 4 Gerrit Notification Bot 2013-08-19 19:12:18 UTC 
Change 79847 had a related patch set uploaded by Hoo man:
Make variant selection menu toggleable by keyboard

https://gerrit.wikimedia.org/r/79847
Comment 5 Gerrit Notification Bot 2013-08-28 19:32:46 UTC 
Change 79847 merged by TheDJ:
Make variant selection menu toggleable by keyboard

https://gerrit.wikimedia.org/r/79847
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links