Last modified: 2013-03-22 19:58:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48434, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46434 - Make all PHPUnit test providers public static
Make all PHPUnit test providers public static
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.21.x
All All
: Lowest minor (vote)
: 1.21.0 release
Assigned To: Krinkle
:
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2013-03-21 20:29 UTC by db [inactive,noenotif]
Modified: 2013-03-22 19:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2013-03-21 20:29:37 UTC 
Some tests have static data provider. It seems that the required phpunit version also allows using of non-static and non-public dataProvider.

Clean up is a good idea here.
Comment 1 Krinkle 2013-03-22 01:55:00 UTC 
Again?

The convention is "public static function" for data providers. I cleaned this up in November (Ic55d539b9a58f448b5 / I9d2b148e57b).

Whomever merged stuff that doesn't do that is naughty (oh!)
Comment 2 Krinkle 2013-03-22 02:17:37 UTC 
Change-Id: I30e5efcd88c516121c454676bd7a18f9b7c8fca6
Comment 3 Umherirrender 2013-03-22 19:58:54 UTC 
(In reply to comment #2)
> Change-Id: I30e5efcd88c516121c454676bd7a18f9b7c8fca6

successfully merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links