Last modified: 2013-03-25 09:17:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48433, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46433 - survey not compatible with SQLite
survey not compatible with SQLite
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Survey (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks: sqlite
  Show dependency treegraph
 
Reported: 2013-03-21 20:22 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-03-25 09:17 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-03-21 20:22:25 UTC
20:16:35 A database query syntax error has occurred.
20:16:35 The last attempted database query was:
20:16:35 "CREATE TABLE IF NOT EXISTS surveys (
20:16:35  survey_id                INTEGER    NOT NULL AUTOINCREMENT PRIMARY KEY,
20:16:35  survey_name              TEXT        NOT NULL, -- String indentifier for the survey
20:16:35  survey_title             TEXT        NOT NULL, -- Title of the survey
20:16:35  survey_enabled           INTEGER             NOT NULL default '0', -- If the survey can be taken by users
20:16:35  survey_header            TEXT                NOT NULL, -- Text to display above the survey
20:16:35  survey_footer            TEXT                NOT NULL, -- Text to display below the survey
20:16:35  survey_thanks            TEXT                NOT NULL, -- Text to display after survey submission
20:16:35  survey_user_type         INTEGER     NOT NULL default '0', -- Type of users that can participate in the survey
20:16:35  survey_namespaces        BLOB                NOT NULL, -- Namespaces on which the survey can be displayed
20:16:35  survey_ratio             INTEGER     NOT NULL, -- Percentage of users to show the survey to
20:16:35  survey_expiry            INTEGER         NOT NULL, -- Coockie expiry time for the survey
20:16:35  survey_min_pages         INTEGER     NOT NULL -- Min amount of pages the user needs to view before getting the survey
20:16:35  )"
20:16:35 from within function "DatabaseBase::sourceFile( /var/lib/jenkins/jobs/mwext-Survey-testextensions-master/workspace/extensions/Survey/sql/Survey.sql )".
20:16:35 Database returned error "1: near "AUTOINCREMENT": syntax error"
Comment 1 Chad H. 2013-03-21 20:24:02 UTC
s/AUTOINCREMENT/AUTO_INCREMENT/
Comment 2 Jeroen De Dauw 2013-03-23 03:16:27 UTC
This is what the code on master looks like:

CREATE TABLE IF NOT EXISTS /*_*/surveys (
  survey_id                SMALLINT unsigned   NOT NULL auto_increment PRIMARY KEY,
  survey_name              VARCHAR(255)        NOT NULL, -- String indentifier for the survey
  survey_title             VARCHAR(255)        NOT NULL, -- Title of the survey
  survey_enabled           TINYINT             NOT NULL default '0', -- If the survey can be taken by users
  survey_header            TEXT                NOT NULL, -- Text to display above the survey
  survey_footer            TEXT                NOT NULL, -- Text to display below the survey
  survey_thanks            TEXT                NOT NULL, -- Text to display after survey submission
  survey_user_type         TINYINT unsigned    NOT NULL default '0', -- Type of users that can participate in the survey
  survey_namespaces        BLOB                NOT NULL, -- Namespaces on which the survey can be displayed
  survey_ratio             TINYINT unsigned    NOT NULL, -- Percentage of users to show the survey to
  survey_expiry            INT unsigned        NOT NULL, -- Coockie expiry time for the survey
  survey_min_pages         TINYINT unsigned    NOT NULL -- Min amount of pages the user needs to view before getting the survey
) /*$wgDBTableOptions*/;
Comment 3 Jeroen De Dauw 2013-03-23 03:18:52 UTC
https://gerrit.wikimedia.org/r/#/c/55452/
Comment 4 Antoine "hashar" Musso (WMF) 2013-03-25 09:17:03 UTC
Tests passed, thank you!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links