Last modified: 2014-06-09 06:18:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47618, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45618 - Watching or unwatching removes the Change Subject link
Watching or unwatching removes the Change Subject link
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nischay Nahata
: javascript
Depends on: 45329
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-01 21:51 UTC by Nischay Nahata
Modified: 2014-06-09 06:18 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nischay Nahata 2013-03-01 21:51:24 UTC 
When clicking on watch or unwatch the 'Change Subject' link disappears.
Comment 1 Helder 2013-03-01 23:17:59 UTC 
...only if javascript is enabled.
Comment 2 Nischay Nahata 2013-03-02 11:41:18 UTC 
I investigated this issue, on clicking 'watch' $.load() is executed which tries to rebuild the command menu by retrieving from the server.. This is wrong and we should be able to build it on client side without interacting with the server.

The actual error happens because the 'Change Subject' button is not build in PHP but in JS which doesn't appear using load()
Comment 3 Nischay Nahata 2013-03-02 12:15:22 UTC 
https://gerrit.wikimedia.org/r/#/c/51834/
Comment 4 Andre Klapper 2013-03-19 16:40:04 UTC 
Patch depends on patch for bug 45329, hence adding dependency.
Comment 5 Gerrit Notification Bot 2013-09-03 13:44:41 UTC 
Change 51834 merged by jenkins-bot:
Watching and Unwatching made 'Change Subject' disappear.

https://gerrit.wikimedia.org/r/51834
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links