Last modified: 2013-04-22 16:14:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46963, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44963 - WebVideoTranscodeJob can return Status instead of bool
WebVideoTranscodeJob can return Status instead of bool
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-13 19:21 UTC by Siebrand Mazeland
Modified: 2013-04-22 16:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2013-02-13 19:21:04 UTC 
At a certain point in WebVideoTranscodeJob::run() $status changes from a bool to a Status object, and is then returned. The return value of Job::run() is expected to be a status, and if it's otherwise, that may lead to issues.

Since Gerrit change #48860, any non-boolean result is interpreted as true, which makes the issues less severe, but this should nevertheless be fixed.
Comment 1 Jan Gerber 2013-02-18 18:34:53 UTC 
looking at the docs Job::run() should only return a boolean not a status.

https://gerrit.wikimedia.org/r/49698 makes sure only boolean is returned.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links