Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46962, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44962 - ChangeNotificationJob returns null instead of bool

Summary:	ChangeNotificationJob returns null instead of bool

Status: VERIFIED FIXED Product: MediaWiki extensions Classification: Unclassified Component: WikidataRepo (Other open bugs) Version: master Hardware: All All Importance: Unprioritized normal (vote) Target Milestone: --- Assigned To: Daniel Kinzler URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2013-02-13 19:14 UTC by Siebrand Mazeland Modified: 2013-02-20 16:21 UTC (History) CC List: 4 users (show) abraham.taherivand daniel.kinzler wikibugs-l wikidata-bugs See Also: 42715 Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2013-02-13 19:14:53 UTC ChangeNotificationJob::run returns null, but this should be boolean true/false. This can lead to issues, although it's now mitigated by Gerrit change #48860. Comment 1 Daniel Kinzler 2013-02-13 21:02:43 UTC Fixed in Ic0f3425d4ec Comment 2 Sam Reed (reedy) 2013-02-14 17:33:25 UTC Merged yesterday Comment 3 abraham.taherivand 2013-02-20 16:21:36 UTC Verified in Wikidata demo sprint 33