Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46960, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44960 - Job returns Status instead of bool

Summary:	Job returns Status instead of bool

Status: RESOLVED FIXED Product: MediaWiki extensions Classification: Unclassified Component: ArticleFeedbackv5 (Other open bugs) Version: master Hardware: All All Importance: Unprioritized normal (vote) Target Milestone: --- Assigned To: Matthias Mullie URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2013-02-13 19:06 UTC by Siebrand Mazeland Modified: 2013-02-22 05:19 UTC (History) CC List: 3 users (show) federicoleva mmullie siebrand See Also: 42715 Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2013-02-13 19:06:55 UTC ArticleFeedbackv5MailerJob returns a Status object instead of a boolean true/false. This can lead to issues running jobs. Comment 1 Siebrand Mazeland 2013-02-13 19:15:20 UTC Mitigated by Gerrit change #48860, but should probably still be fixed. Comment 2 Matthias Mullie 2013-02-15 13:08:42 UTC Fix in Gerrit: https://gerrit.wikimedia.org/r/#/c/49235/ Comment 3 Nemo 2013-02-22 05:19:25 UTC Merged by Nikerabbit.