Last modified: 2013-09-04 09:01:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46947, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44947 - Remove "requires JavaScript" from preference texts


Summary:	Remove "requires JavaScript" from preference texts

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.21.x
Hardware:	All All

Importance:	Low minor with 1 vote (vote)
Target Milestone:	---
Assigned To:	Rahul Maliakkal

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	messages
	Show dependency tree / graph

Reported:	2013-02-13 11:38 UTC by Nemo
Modified:	2013-09-04 09:01 UTC (History)
CC List:	9 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch Link (41 bytes, text/plain) 2013-02-24 18:07 UTC, Rahul Maliakkal	Details
Add an attachment (proposed patch, testcase, etc.)

Description Nemo 2013-02-13 11:38:04 UTC

«Some preferences end with (requires JavaScript), but it is not consistently used, and given that practically everyone has javascript support these days, but a lot of people don't really know what it is, wouldn't it be better to remove the warnings?»

There are 6 such preferences in core.

Comment 1 Rahul Maliakkal 2013-02-24 18:07:29 UTC

Created attachment 11836 [details]
Patch Link

Comment 2 Rahul Maliakkal 2013-02-24 18:09:48 UTC

Comment on attachment 11836 [details]
Patch Link

>

Comment 3 Rahul Maliakkal 2013-02-24 18:10:58 UTC

I am sorry for the mess
https://gerrit.wikimedia.org/r/#/c/50614/

Comment 4 Betacommand 2013-02-24 18:18:32 UTC

Actually a lot of users JavaScipt isnt supported. Or in other cases especially on mobile browsers it causes inconsistencies (Lynx browser does not support JavaScript)

Comment 5 Rahul Maliakkal 2013-02-24 18:18:50 UTC

Gerrit change #50614

Comment 6 Jesús Martínez Novo (Ciencia Al Poder) 2013-02-24 18:21:50 UTC

removing javascript keyword since it has nothing to do with JavaScript modifications.

Comment 7 Andre Klapper 2013-02-25 14:44:02 UTC

Rahul: Thanks for the patch!

Betacommand: See comment 0 - it's not consistently used anyway.

Comment 8 Waldir 2013-02-27 17:59:08 UTC

(In reply to comment #7)
> Rahul: Thanks for the patch!
> 
> Betacommand: See comment 0 - it's not consistently used anyway.

I would prefer us to err on the other side, then. What about adding those preferences items via Javascript? (only semi-joking)

Comment 9 MZMcBride 2013-02-27 18:02:52 UTC

I'm not sure about removing the warning text.

Comment 10 Gerrit Notification Bot 2013-09-03 13:03:26 UTC

Change 50614 had a related patch set uploaded by Siebrand:
(Bug 44947) Removed "requires JavaScript" from preference texts

https://gerrit.wikimedia.org/r/50614

Comment 11 Gerrit Notification Bot 2013-09-04 08:56:20 UTC

Change 50614 merged by jenkins-bot:
Removed "requires JavaScript" from preference texts

https://gerrit.wikimedia.org/r/50614

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links