Last modified: 2013-04-25 13:03:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46680, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44680 - Meta pages use non-existing meta.wikipedia.org/apple-touch-icon.png
Meta pages use non-existing meta.wikipedia.org/apple-touch-icon.png
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 27911
  Show dependency treegraph
 
Reported: 2013-02-05 14:49 UTC by Nemo
Modified: 2013-04-25 13:03 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2013-02-05 14:49:35 UTC
1) [[m:Special:Random]]
2) View source
3) Find <link rel="apple-touch-icon" href="//meta.wikipedia.org/apple-touch-icon.png" />
4) Get a 404

Reason is obvious, see bug 27911:
'wgAppleTouchIcon' => array(
[...]
    'wiki' => 'http://$lang.$site.org/apple-touch-icon.png',
[...]
Comment 1 Faidon Liambotis 2013-04-24 13:48:53 UTC
foundationwiki is also broken in the same way, so whatever the fix is it should account for more than just meta.
Comment 2 Gerrit Notification Bot 2013-04-24 15:45:07 UTC
Related URL: https://gerrit.wikimedia.org/r/60670 (Gerrit Change Ib5554c547295d9b53b4f554e2773a4d7c14f8c6a)
Comment 3 Tomasz W. Kozlowski 2013-04-24 22:56:25 UTC
This is now fixed with the above Gerrit change – we are no longer linking to 404, but both wikis are using the Wikipedia icon from https://bits.wikimedia.org/apple-touch/wikipedia.png for now. 

This can be fixed by creating new icons and committing them into 'docroot/bits/apple-touch/wmf.png' and /docroot/bits/apple-touch/community.png' and adding…

    'wikimedia' => '//bits.wikimedia.org/apple-touch/wmf.png',
    'foundationwiki' => '//bits.wikimedia.org/apple-touch/wmf.png',
    'metawiki' => '//bits.wikimedia.org/apple-touch/community.png',

… to InitialiseSettings.php, should such a need arise.

I can imagine other wikis (Wikispecies, Wikidata) wanting to have their own Apple Touch icons, but this should be taken care of in new bugs.
Comment 4 Tomasz W. Kozlowski 2013-04-25 13:03:26 UTC
After an IRC discussion with Krinkle, I submitted Gerrit change #60777 which is a change of heart — we'll be keeping icons in docroot from now on, and only linking to project-specific ones from bits.wm.org/apple-touch.

What this means for this bug specifically is that we are no longer linking to non-existing files /at all/ — having wgAppleTouchIcon => array( 'default' => false, ) means that MediaWiki will not generate any links to Touch icons in HTML <head /> (this fixes bug 19392).

Since there might be a need to have per-wiki specific icons, they can be committed into the appropriate docroot. For wikis with subdomain names (such as $lang.wiktionary.org), they can be defined in InitialiseSettings.php as shown above and committed into /docroot/bits/apple-touch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links