Last modified: 2013-02-12 11:31:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46522, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44522 - [Regression] "Edit on double click" is broken (mw.util.$content undefined)
[Regression] "Edit on double click" is broken (mw.util.$content undefined)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.21.x
All All
: Normal normal (vote)
: 1.21.0 release
Assigned To: Krinkle
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-30 20:40 UTC by Danny B.
Modified: 2013-02-12 11:31 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Danny B. 2013-01-30 20:40:35 UTC
Edit on double click does not work on Wikimania 2013.
Comment 1 Sam Reed (reedy) 2013-01-31 10:56:22 UTC
(In reply to comment #0)
> Edit on double click does not work on Wikimania 2013.

Wassat?
Comment 2 Danny B. 2013-01-31 12:10:03 UTC
So after some playing with this, I found the following:

Exception thrown by mediawiki.action.view.dblClickEdit: mw.util.$content is null
TypeError: mw.util.$content is null
Comment 3 Andre Klapper 2013-01-31 12:36:20 UTC
I still have no idea what "Edit on double click" is, sorry. :)
Steps to reproduce are welcome, in general.
Comment 4 the wub 2013-01-31 13:17:20 UTC
It's a Preferences option, under the Editing tab. "Edit pages on double click (requires JavaScript)"
Comment 5 Alex Monk 2013-01-31 17:36:52 UTC
WFM
Comment 6 Andre Klapper 2013-02-01 00:49:48 UTC
Works for me too with Firefox 17 on Fedora 16.
More info needed to reproduce (browser, system).
Comment 7 Danny B. 2013-02-01 02:23:04 UTC
FF18.0.1 @ WXPSP2 up-to-date

Works on any other site but WM2013.

Error message provided in comment #2.

No JS gadgets turned on.
Comment 8 Danny B. 2013-02-01 02:23:54 UTC
Does not work with either debug on or off. In both cases returns the error message.
Comment 9 NordNordWest 2013-02-01 11:14:00 UTC
Doesn't work on any Wikipedia or Commons for me (Mac 10.4.11, Safari).
Comment 10 Krinkle 2013-02-03 07:29:27 UTC
Moving to JavaScript component, this bug has nothing to do with ResourceLoader whatsoever.

Updating bug to be a general mediawiki regression.
Comment 11 Krinkle 2013-02-03 07:32:44 UTC
I can't reproduce this bug on latest master

* Log in
* Preferences > Editing > [x] Edit on double click
* Open a random page
* Double click on content area
* Edit action opens

Works fine for me in Chrome.
Comment 12 Christian Thiele 2013-02-03 22:33:11 UTC
Works for me in Opera, Chrome and FF. Doesn't work in IE9.

In line 5 of mediawiki.action.view.dblClickEdit.js the following statement fails: 

mw.util.$content.dblclick 

The reason is, that mw.util.$content is null. Running the same JavaScript after everything is loaded works fine, so it seems to be a problem with the order of execution.
Comment 13 Michael M. 2013-02-05 08:42:10 UTC
The last change to dblClickEdit.js, Ie8a35700bc9e74b24f234ea682ad25375e18bda4, removed the code to execute it on DOMContentLoaded. So now it may be executed  before mw.util.$content is set, depending on the order the scripts get loaded and executed. Just re-add the $( document ).ready(), and it probably will work again for all.
Comment 14 Krinkle 2013-02-06 01:59:46 UTC
Change-Id: I5f0388ae1307302bacebc9aa86bb83ceb82e30fb
Comment 15 Krinkle 2013-02-12 11:31:29 UTC
Removing "For some" from summary. The "Edit on double click" feature is disabled by default, if you enable it this bug was consistently reproducible for all users on all wikis in all browsers. It was a general code bug, not environmental related.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links