Last modified: 2013-11-05 19:00:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46483, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44483 - Parsoid should support passing on an authenticated user's read right (when MW API supports that)


Summary:	Parsoid should support passing on an authenticated user's read right (when MW...

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:
Whiteboard:
Keywords:

Duplicates:	44313 (view as bug list)
Depends on:	12251 30348
Blocks:
	Show dependency tree / graph

Reported:	2013-01-29 20:44 UTC by James Forrester
Modified:	2013-11-05 19:00 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-01-29 20:44:16 UTC

[Very much a longer-term enhancement.]

Parsoid doesn't currently have support for passing on an authenticated user's read right when fetching the wikitext (because the API doesn't support that yet).

Comment 1 Gabriel Wicke 2013-01-30 23:35:05 UTC

Passing on the cookie header from the VisualEditor extension to Parsoid and then from Parsoid back to the API might be enough to enable this. Definitely worth a try.

Comment 2 James Forrester 2013-02-07 03:25:11 UTC

*** Bug 44313 has been marked as a duplicate of this bug. ***

Comment 3 Gerrit Notification Bot 2013-09-21 09:12:06 UTC

Change 85414 had a related patch set uploaded by GWicke:
WIP Bug 44483: Forward Cookie header to API

https://gerrit.wikimedia.org/r/85414

Comment 4 Krinkle 2013-09-24 12:03:59 UTC

Random idea:

Could Parsoid be made private (already is, though last I checked it still has a public IP) and use an internal API instead of the public API. Then the responsibility for user rights lays in MediaWiki land, and when the request is in Parsoid we can assume it is authenticated and thus Parsoid can have unrestricted access.

Comment 5 Gabriel Wicke 2013-10-08 19:27:18 UTC

(In reply to comment #4)
> Random idea:
> 
> Could Parsoid be made private (already is, though last I checked it still
> has a
> public IP) and use an internal API instead of the public API. Then the
> responsibility for user rights lays in MediaWiki land, and when the request
> is
> in Parsoid we can assume it is authenticated and thus Parsoid can have
> unrestricted access.

That is what we'll have to do in the longer term once we store HTML. Parsoid might not even be involved in that case, only the content API / storage is. See https://www.mediawiki.org/wiki/User:GWicke/Notes/Storage for the current WIP on that.

Comment 6 Gerrit Notification Bot 2013-10-16 23:24:50 UTC

Change 85414 merged by jenkins-bot:
Bug 44483: Forward Cookie header to API

https://gerrit.wikimedia.org/r/85414

Comment 7 Gabriel Wicke 2013-10-16 23:29:42 UTC

Cookies are now forwarded, and caching is disabled if a cookie is set. Closing this bug as fixed. A content API will have to do its own auth.

Comment 8 Gerrit Notification Bot 2013-10-22 01:10:56 UTC

Change 91111 had a related patch set uploaded by Jforrester:
Support private wikis by forwarding Cookie: headers to Parsoid

https://gerrit.wikimedia.org/r/91111

Comment 9 Gabriel Wicke 2013-10-22 22:04:35 UTC

Closing again.

Comment 10 Gerrit Notification Bot 2013-11-05 19:00:31 UTC

Change 91111 merged by jenkins-bot:
Support private wikis by forwarding Cookie: headers to Parsoid

https://gerrit.wikimedia.org/r/91111

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links