Last modified: 2013-06-13 13:14:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46310, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44310 - Thumbnail cache should be automatically discarded after 6 months
Thumbnail cache should be automatically discarded after 6 months
Status: NEW
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 41371
  Show dependency treegraph
 
Reported: 2013-01-24 12:06 UTC by Marco
Modified: 2013-06-13 13:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Marco 2013-01-24 12:06:36 UTC
Thumbnails which are older than 6 months should automatically be deleted to force creation of new ones. Reasons:

* Updated image scalers: Many thumbnails were created with image scalers which are deprecated by now. There are plenty of examples where thumbnails older than 6 years are not sharpened (jpeg sharpening was introduced later, I think) or broken (Quite a few svg rendering issues were fixed over the years)
* Many bug reports about cache issues: There are many(!) bug reports open right now complaining about caching issues with thumnails.
* Manual purge does not scale.
* Clean up of unused data: I am not sure about that but possibly the deletion of old thumbnails makes free space available again on the hard drives.
Comment 1 Andre Klapper 2013-01-28 16:29:05 UTC
Also see http://lists.wikimedia.org/pipermail/wikitech-l/2012-October/064011.html

(In reply to comment #0)
> * Many bug reports about cache issues: There are many(!) bug reports open
> right now complaining about caching issues with thumnails.

This proposal will not fix that problem.
Comment 2 MZMcBride 2013-02-03 02:33:09 UTC
Is this bug a matter of setting [[mw:Manual:$wgThumbnailEpoch]] appropriately?
Comment 3 MZMcBride 2013-02-03 02:36:56 UTC
Assigning to Reedy.
Comment 4 MZMcBride 2013-02-03 02:41:16 UTC
(In reply to comment #3)
> Assigning to Reedy.

If you try to assign a bug without leaving a comment, Bugzilla throws an error and asks you to go back in your Web browser. However, when you go back in your Web browser, the assigned to field is not preserved. Grr.
Comment 5 MZMcBride 2013-02-03 02:42:54 UTC
(In reply to comment #0)
> Thumbnails which are older than 6 months should automatically be deleted to
> force creation of new ones.

Why six months? I think thirty days would be more likely to be expected, given other cache expiries.
Comment 6 Marco 2013-02-03 10:41:11 UTC
Image Scalers do not get updated that much. 30 days would be too much of an effort for the servers. (Keep in mind the servers have to go through ALL files in 30 days to keep up...)
Comment 7 Bawolff (Brian Wolff) 2013-02-03 10:54:33 UTC
(In reply to comment #5)
> (In reply to comment #0)
> > Thumbnails which are older than 6 months should automatically be deleted to
> > force creation of new ones.
> 
> Why six months? I think thirty days would be more likely to be expected,
> given
> other cache expiries.

If we did that, we probably might as well just get rid of the thumbnail cache and rely on squid/varnish only. [Saying that without looking at the varnish cache hit ratio or average time things get stuck in varnish cache, etc take with salt]
Comment 8 Tim Starling 2013-02-04 03:26:22 UTC
(In reply to comment #2)
> Is this bug a matter of setting [[mw:Manual:$wgThumbnailEpoch]]
> appropriately?

No, $wgThumbnailEpoch has no effect when the 404 handler is used. We could delete files from the backend based on modification time, and prevent long-term caching in varnish with a Cache-Control header if that's not done already.

(In reply to comment #7)
> If we did that, we probably might as well just get rid of the thumbnail cache
> and rely on squid/varnish only. [Saying that without looking at the varnish
> cache hit ratio or average time things get stuck in varnish cache, etc take
> with salt]

We would like to get rid of the thumbnail backend storage and use varnish only, for various reasons. But we wouldn't try to do it with a 30 day expiry time. 6 months is probably reasonable.

This won't solve the caching issues or significantly reduce the need for manual purging, so those bugs should be addressed separately.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links