Last modified: 2013-01-27 09:43:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 44231 - Gadgets tab on Special:Preferences badly formatted
Gadgets tab on Special:Preferences badly formatted
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: code_quality
  Show dependency treegraph
Reported: 2013-01-22 05:10 UTC by Danny B.
Modified: 2013-01-27 09:43 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Danny B. 2013-01-22 05:10:56 UTC
The Gadgets tab on Special:Preferences is badly formatted.

1) Section headers are <h1> instead of <h2>

2) There is absolutely no need to wrap it in the table at all, however, if by any chance there would be any need (which?), then don't output unnecessary
  <td class="mw-label"><label>&nbsp;</label></td>
at the beginning which causes ugly left padding of the entire content except for the header.

Feel free to split this to two bugs if necessary.
Comment 1 Danny B. 2013-01-27 09:43:55 UTC
3) <label> can contain only inline elements, however, gadget description allows to make block content (typically with longer description divided into paragraphs) thus the HTML output in such case is invalid. Because gadget descriptions should be descriptive, the <label> element should be removed in favour of that. On top of this, the checkbox and the description should be in separated table cells, thus the block level description won't start under the checkbox but aside it.

Note You need to log in before you can comment on or make changes to this bug.