Last modified: 2013-01-27 09:43:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46231, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44231 - Gadgets tab on Special:Preferences badly formatted
Gadgets tab on Special:Preferences badly formatted
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://test2.wikipedia.org/wiki/Speci...
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2013-01-22 05:10 UTC by Danny B.
Modified: 2013-01-27 09:43 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Danny B. 2013-01-22 05:10:56 UTC
The Gadgets tab on Special:Preferences is badly formatted.

1) Section headers are <h1> instead of <h2>

2) There is absolutely no need to wrap it in the table at all, however, if by any chance there would be any need (which?), then don't output unnecessary
  <td class="mw-label"><label>&nbsp;</label></td>
at the beginning which causes ugly left padding of the entire content except for the header.

Feel free to split this to two bugs if necessary.
Comment 1 Danny B. 2013-01-27 09:43:55 UTC
3) <label> can contain only inline elements, however, gadget description allows to make block content (typically with longer description divided into paragraphs) thus the HTML output in such case is invalid. Because gadget descriptions should be descriptive, the <label> element should be removed in favour of that. On top of this, the checkbox and the description should be in separated table cells, thus the block level description won't start under the checkbox but aside it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links