Last modified: 2014-06-19 12:47:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46210, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44210 - Translation notifications should always be delivered via Translation Notification Bot, including at Meta
Translation notifications should always be delivered via Translation Notifica...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TranslationNotifications (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: MW 1.24 version
Assigned To: Nobody - You can work on this!
https://meta.wikimedia.org/wiki/Speci...
:
Depends on:
Blocks: 47811
  Show dependency treegraph
 
Reported: 2013-01-21 15:37 UTC by MA
Modified: 2014-06-19 12:47 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MA 2013-01-21 15:37:40 UTC
I do not know which criteria uses the extension to choose one or another account but when a translation notification is issued (at Meta, via the notifytranslators special page) some (most of them) are delivered by the personal account of the translation administrator who issued the command <https://meta.wikimedia.org?diff=prev&oldid=5043916> while others are notified via the ad hoc account <https://meta.wikimedia.org/wiki/Special:Contributions/Translation_Notification_Bot>.

* Notifications should be always sent by the TNBot no matter the project.

* Edits on user talk pages by TNBot should not be marked as "minor" so it is possible for the projects to flag the account as bot, to avoid flooding/cluttering of recentchanges (which already happens now at Meta, each time a translation notification is issued, recentchanges becomes unusable) & possibilitating at the same time that the user receives the orange bar "you have new messages" (since only bots have the 'nominornewtalk' right).

Thanks.
Comment 1 MA 2013-02-03 22:05:03 UTC
Regarding third poing, see also bug 40839. Bug 41637 might be of general interest too.
Comment 2 MA 2013-02-03 22:05:29 UTC
* poing -> point
Comment 3 Nemo 2013-02-03 23:12:17 UTC
(In reply to comment #0)
> * Notifications should be always sent by the TNBot no matter the project.
> 
> * Edits on user talk pages by TNBot should not be marked as "minor" [...]

Note that the second is already the case, only the first had to be fixed.
I think this makes sense, however it may need to be a configuration setting or something else which allows the sysadmin not to have a specific account for the Translation Notification Bot, which might be undesirable for wikis which don't need cross-wiki notifications, especially until bug 39104 is fixed.
Comment 4 Niklas Laxström 2013-02-04 20:51:22 UTC
The current criteria is very simple: if user "talk page on another wiki", then it is delivered via a Bot.
Comment 5 Amir E. Aharoni 2013-04-01 08:46:55 UTC
Patch:
https://gerrit.wikimedia.org/r/#/c/56896/
Comment 6 Amir E. Aharoni 2013-04-01 14:13:22 UTC
Merged. Will be deployed some time soon.
Comment 7 Nemo 2013-04-29 06:58:51 UTC
The fix is probably broken, first such edit on wikidatawiki caused bug 47811.
https://www.wikidata.org/w/index.php?title=User_talk:Vogone&diff=prev&oldid=32364841
Comment 8 Nemo 2013-05-28 06:24:38 UTC
(In reply to comment #7)
> The fix is probably broken, first such edit on wikidatawiki caused bug 47811.
> https://www.wikidata.org/w/index.php?title=User_talk:
> Vogone&diff=prev&oldid=32364841

Amir, any plan to fix it?
Comment 9 Kunal Mehta (Legoktm) 2013-07-16 06:13:38 UTC
The issue with the fix is that it won't create the account if it doesn't exist yet.

A fix like what the AbuseFilter does (https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/master/AbuseFilter.class.php#L1624) should work.
Comment 10 Nemo 2014-06-17 15:36:53 UTC
(In reply to Kunal Mehta (Legoktm) from comment #9)
> The issue with the fix is that it won't create the account if it doesn't
> exist yet.
> 
> A fix like what the AbuseFilter does
> (https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/master/
> AbuseFilter.class.php#L1624) should work.

getFilterUser currently at https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/9a632d04ec0812d49d0761ce1cb20d154bf7760c/AbuseFilter.class.php#L1676
Comment 11 Gerrit Notification Bot 2014-06-17 16:59:13 UTC
Change 140157 had a related patch set uploaded by Kunalgrover05:
Make new user if not present

https://gerrit.wikimedia.org/r/140157
Comment 12 Gerrit Notification Bot 2014-06-19 12:28:03 UTC
Change 140157 merged by jenkins-bot:
Make new user if not present

https://gerrit.wikimedia.org/r/140157

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links