Last modified: 2014-05-06 15:39:52 UTC
With https://gerrit.wikimedia.org/r/#/c/39056/ we renamed the old $realm to $wmfRealm. Tim mentioned: > It should be $wmgRealm, for consistency with other globals. > wmg = Wikimedia global, wmf = Wikimedia function. We probably want to do that after the EQIAD migration though.
[ Set tracking bug 39106 (EQIAD migration) as blocker. ]
If you do this, you should also rename the following: $wmfConfigDir $wmfDatacenter $wmfExtendedVersionNumber $wmfHostnames $wmfSwiftBigWikis $wmfSwiftConfig $wmfSwiftShardCommon $wmfSwiftShardLocal $wmfUdp2logDest $wmfVersionNumber $wmfThrottlingExceptions $wmfStandardAutoPromote $wmfUseArticleCreationWorkflow It looks to me like "$wmg" variables are used for particular features, e.g. which extensions to enable or setting a particular "$wg" variable. And except for the last three, it looks like "$wmf" variables are used for global configuration. Don't forget to check extensions/WikimediaMaintenance and /usr/local/bin stuff too.
I have already mailed people who are on the cc list of this bug. One of them told me to comment on this so that this bug would be assigned to me. So, could someone assign this bug to me?
(In reply to comment #3) > I have already mailed people who are on the cc list of this bug. That's not a good idea if there is nothing private or off-topic to discuss - instead, comment on this bug report. Assigned to you now.
Could you please mentor me for this bug fixing?
Hello, I can mentor you for this bug. Please poke me on IRC. Dereckson (I'm on #wikimedia-tech and #wikimedia-dev, I figure the first is more indicated for this kind of configuration bug).
Is it okay if I mail you?
I don't see much sense in relying on one person only in private, when there's an unlimited number of people who can help you in public. The knowledge of the crowd is one of the advantages of free software. :)
I concur. A little explanation for the bug status. We use: * UNCONFIRMED for bugs still needing clarification * NEW for (confirmed) new bugs * ASSIGNED for bug someone is working on (so if there is an assignee, status should be ASSIGNED, to avoid someone else meanwhile work on it) * PATCH_TO_REVIEW when bug has a code solution, pending code review * RESOLVED when the bug has been solved * VERIFIED for the areas using quality assurance, after the QA occurred
Created attachment 13733 [details] Renamed $wmf to $wmg in mediawiki-config Renamed $wmf* to $wmg* for consistency with other global variables. $wmf= Wikimedia function wmg= Wikimedia global
Change 94354 had a related patch set uploaded by TTO: Renamed $wmfConfigDir to $wmgConfigDir in mediawiki-config https://gerrit.wikimedia.org/r/94354
Change 94503 had a related patch set uploaded by Arav93: Renamed $wmf* to $wmg* to improve consistency https://gerrit.wikimedia.org/r/94503
Change 94503 abandoned by Arav93: Renamed $wmf* to $wmg* to improve consistency Reason: Revision added : https://gerrit.wikimedia.org/r/#/c/94354/ https://gerrit.wikimedia.org/r/94503
Created attachment 13753 [details] Renamed $wmf to $wmg in mediawiki-config
(In reply to comment #14) > Created attachment 13753 [details] > Renamed $wmf to $wmg in mediawiki-config Patch is as broken as the patch that was uploaded to Gerrit, including lots of noise from conflicts like "<<<<<<< HEAD". Please follow http://www.mediawiki.org/wiki/Gerrit/Tutorial and upload patches to Gerrit instead of Bugzilla, and fix potential issues in them. Thanks.
Ok, Sure.
Change 94354 abandoned by Arav93: Renamed $wmfConfigDir to $wmgConfigDir in mediawiki-config Reason: Uploading new patch. https://gerrit.wikimedia.org/r/94354
Change 94598 had a related patch set uploaded by Arav93: Renamed $wmf* to $wmg* https://gerrit.wikimedia.org/r/94598
Could someone review? :)
Please don't ask for review after 40 minutes. Every comment creates bugmail and it is obvious to everybody anyway that there is a patch due to comment 18. Also, as I had written several times on IRC, please AMEND changes instead of creating completely new numbers in Gerrit: https://www.mediawiki.org/wiki/Git/Tutorial#Amending_a_change
As mentioned three times now (comment 2, and twice in Gerrit), this change also requires a corresponding change to the mediawiki/extensions/WikimediaMaintenance project.
How am I supposed to do that?
And I'm sorry about spamming.
Change 94609 had a related patch set uploaded by Arav93: Renamed $wmf* to $wmg* for consistency. Bug 43956 required a change in this repository as well. https://gerrit.wikimedia.org/r/94609
Change 94598 abandoned by Arav93: Renamed $wmf* to $wmg* Reason: Adding an improved patch. https://gerrit.wikimedia.org/r/94598
Could someone tell why this (https://gerrit.wikimedia.org/r/#/c/101820/) cannot be merged?
Somebody still needs to review the patch...
Are you sure that's the only reason?
