Last modified: 2013-09-19 16:33:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45679, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 43679 - mb_check_encoding() change in php 5.4.10
mb_check_encoding() change in php 5.4.10
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.21.x
All All
: Lowest normal with 1 vote (vote)
: 1.22.0 release
Assigned To: Kevin Israel (PleaseStand)
: newphp
Depends on:
Blocks: 30092
  Show dependency tree / graph
 
Reported: 2013-01-06 13:47 UTC by Platonides
Modified: 2013-09-19 16:33 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2013-01-06 13:47:14 UTC 
testIsUtf8WithMbstring is failing in PHP 5.4.10 with the strings:
- "\xf8\x88\x80\x80\x80" (#6)
- "\xfc\x84\x80\x80\x80\x80" (#7)
- "\xf7\xbf\xbf\xbf" (#11)
- "\xfb\xbf\xbf\xbf\xbf" (#12)
- "\xf4\x90\x80\x80" (#18)

mb_check_encoding( $string, 'UTF-8' ) is returning false in php 5.4.10 (they made their checks stricter?)


Hashar, I'm assigning this to you as 750db30d9 author.
Comment 1 Antoine "hashar" Musso (WMF) 2013-01-07 19:03:38 UTC 
Did it succeed with a previous 5.4 release or did it start failing with 5.4.10 ?
Comment 2 Antoine "hashar" Musso (WMF) 2013-01-22 07:45:06 UTC 
I do not yet have time to look at this for now, I guess we want our test to react differently whenever PHP is 5.4 or later.
Comment 3 Jan Zerebecki 2013-04-05 13:47:12 UTC 
This happens for me on PHP 5.4.4-14 (Debian).
Most likely this item from the PHP 5.4.0 NEWS file indicates the change: Ill-formed UTF-8 check for security enhancements. (Rui)
Comment 4 Gerrit Notification Bot 2013-05-24 15:32:03 UTC 
Related URL: https://gerrit.wikimedia.org/r/65300 (Gerrit Change I026eff69236187ce3d2ff2fc261a5e1d9cd88b24)
Comment 5 Jan Zerebecki 2013-05-25 09:59:58 UTC 
Found https://gerrit.wikimedia.org/r/#/c/48743/ which also intends to fix this bug.
Comment 6 Andre Klapper 2013-08-08 07:53:34 UTC 
Both patches mentioned here have received -1's and likely need rework.
Comment 7 Gerrit Notification Bot 2013-09-16 04:34:15 UTC 
Change 48743 had a related patch set uploaded by PleaseStand:
Adapt StringUtils::isUtf8 to the top of Unicode at U+10FFFF

https://gerrit.wikimedia.org/r/48743
Comment 8 Gerrit Notification Bot 2013-09-19 16:12:41 UTC 
Change 48743 merged by jenkins-bot:
Adapt StringUtils::isUtf8 to the top of Unicode at U+10FFFF

https://gerrit.wikimedia.org/r/48743
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links