Last modified: 2013-07-25 07:07:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45381, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43381 - ArticleFeedbackv5 query issue with SQLite
ArticleFeedbackv5 query issue with SQLite
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: Low major (vote)
: ---
Assigned To: Matthias Mullie
:
Depends on:
Blocks: sqlite
  Show dependency treegraph
 
Reported: 2012-12-24 14:23 UTC by Dereckson
Modified: 2013-07-25 07:07 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dereckson 2012-12-24 14:23:31 UTC
SQLite doesn't have boolean type, so the following query fails:

SELECT af_id,af_net_helpfulness,af_relevance_sort,rating.aa_response_boolean AS yes_no FROM aft_article_feedback LEFT JOIN aft_article_answer "rating" ON ((rating.aa_feedback_id = af_id) AND rating.aa_field_id IN ('-1','1','16') ) LEFT JOIN aft_article_answer "comment" ON ((comment.aa_feedback_id = af_id) AND comment.aa_field_id IN ('-1','2','17') ) INNER JOIN page ON ((page_id = af_page_id)) INNER JOIN watchlist ON (wl_user = '1' AND (wl_namespace = page_namespace) AND (wl_title = page_title)) WHERE (af_is_deleted IS FALSE) AND (af_oversight_count = 0) AND (af_is_hidden IS FALSE) AND af_form_id IN ('1','6') ORDER BY af_id DESC LIMIT 2 

Function: ArticleFeedbackv5Fetch::run
Database error: "1: no such column: FALSE".
Comment 1 Gerrit Notification Bot 2013-05-16 14:36:41 UTC
Related URL: https://gerrit.wikimedia.org/r/64063 (Gerrit Change I63bc076651ca0f52d61fcac32cc6b3be48940632)
Comment 2 Matthias Mullie 2013-06-13 11:57:07 UTC
I had misinterpreted this report.
It is about the old schema. The problem was not about 'boolean' datatype being used in the creation of the array, which will be understood by SQLite (http://www.sqlite.org/datatype3.html#affinity)
The problem was that the queries used to use TRUE/FALSE keywords, which don't exist.

These are no longer present.
Comment 3 Gerrit Notification Bot 2013-06-13 11:57:22 UTC
https://gerrit.wikimedia.org/r/64063 (Gerrit Change I63bc076651ca0f52d61fcac32cc6b3be48940632) | change ABANDONED [by Matthias Mullie]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links