Last modified: 2013-04-22 16:14:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45373, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 43373 - CTRL+Click on "Feedback from my watched pages »" should open the link in a new tab


Summary:	CTRL+Click on "Feedback from my watched pages »" should open the link in a ne...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ArticleFeedbackv5 (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Matthias Mullie

URL:
Whiteboard:
Keywords:	javascript

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-12-23 20:02 UTC by Helder
Modified:	2013-04-22 16:14 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2012-12-23 20:02:28 UTC

Currently, the link "Feedback from my watched pages »" opens
https://en.wikipedia.org/wiki/Special:ArticleFeedbackv5Watchlist?ref=watchlist
in the same page even if I press CTRL while clicking in the link. This is not the expected behaviour (at least on Google Chrome), since all other links open in a new tab if I use CTRL+Click.

Comment 1 Dereckson 2012-12-24 13:41:03 UTC

[ Analysis ]

This link is added in JavaScript, by code located at modules/ext.articleFeedbackv5/ext.articleFeedbackv5.watchlist.js.

It creates the link, and adds an on click event, handled by a ClickTracking code.


[ Possible solution ]

Add a kludge to the relevant ClickTracking function to handle itself the click event:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ArticleFeedbackv5.git;a=blob;f=modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.track.js;h=f2437621bea89f56ffe9897de23a079be14c92e2;hb=HEAD#l141

        if (e.ctrlKey) {
            //Call a new method to manage ourself the event and open the link in a new window
        } else {
            //Send the event to the browser, current IE/Firefox code at the bottom of the method
        }


[ Relevant links ]

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ArticleFeedbackv5.git;a=blob;f=modules/ext.articleFeedbackv5/ext.articleFeedbackv5.watchlist.js;h=75096d512679f8e2169ce2063040e17c1201c9f4;hb=HEAD ->

Comment 2 Matthias Mullie 2013-01-07 13:09:22 UTC

Patch submitted: https://gerrit.wikimedia.org/r/#/c/42541/

Comment 3 Alex Monk 2013-03-17 19:47:14 UTC

Merged on the 13th.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links