Last modified: 2013-01-23 15:13:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45200, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43200 - wbcreateclaim overwrites existing claims when revision ID is used
wbcreateclaim overwrites existing claims when revision ID is used
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest critical (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on: 43326
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-17 14:37 UTC by Daniel A. R. Werner
Modified: 2013-01-23 15:13 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel A. R. Werner 2012-12-17 14:37:20 UTC
When adding more than one Claim, only the first one created will be there after reloading the page. The API calls are done successfully and two different Claim GUIDs are returned when creating two claims. This seems to be a backend error, probably related to the revision ID handling.
Comment 1 Daniel A. R. Werner 2012-12-17 14:45:22 UTC
Correction: Not the first Claim added will still be there after reload, it is the last one added.
Comment 2 tobias.gritschacher 2012-12-17 16:53:15 UTC
I think the backend is already doing something with the revision ID we're sending in the request. But it seems to do the wrong thing. We're sending the base revision ID (the one we got when the site was loaded) each time a new statement or claim is created. The backend semms to not patch properly as only the newest created claim or statement is kept and all others are thrown away. If we send "0" as revision ID when creating a new claim or statement, everything works fine. I assume this case is handled differently in the backend.
Comment 3 Jeroen De Dauw 2012-12-18 12:57:48 UTC
I added a test to check for this bug: https://gerrit.wikimedia.org/r/39195

It's passing, so I cannot reproduce the issue.
Comment 4 Jeroen De Dauw 2012-12-18 13:18:03 UTC
Talked to Tobi. Issue occurs when making a request when an old rev id, which will cause claims in later revisions to be removed. This is likely a patching issue, and perhaps due to EntityDiff not containing claims (bug 43021).
Comment 5 Jeroen De Dauw 2012-12-20 16:04:00 UTC
Started work on cleaning up EntityDiff and its patching code https://gerrit.wikimedia.org/r/#/c/39229/
Comment 6 tobias.gritschacher 2013-01-18 11:40:18 UTC
some more changes addressing this: I2b8fe753, Ifbdbfcc6, I2662bc13
Comment 7 abraham.taherivand 2013-01-23 15:13:53 UTC
Verified in Wikidata demo sprint 29

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links