Last modified: 2013-01-25 19:45:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45135, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43135 - VisualEditor: Deleting content between a heading and an alien fails?
VisualEditor: Deleting content between a heading and an alien fails?
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: 41948
  Show dependency treegraph
 
Reported: 2012-12-14 18:47 UTC by James Forrester
Modified: 2013-01-25 19:45 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2012-12-14 18:47:07 UTC
In https://en.wikipedia.org/w/index.php?title=Lynn_Hill&oldid=528045441 (and other versions), go into VE, go to the bottom, delete the list item (and so the list) from the External links section.

ve.instances[0].documentModel.data confirms that the model has this removed - "/heading" object followed by the alienated table from the "{{Authority control}}" template - but on diff Parsoid thinks that there is no change in this area. Is this is a Parsoid, or is change marking broken (or both)?
Comment 1 Roan Kattouw 2012-12-19 20:48:38 UTC
This is probably a selser (Parsoid) issue. There is no change marking for removals, selser detects these based on DSR discontinuities.

Provisionally CCing Mark, once I get time to investigate this properly and figure out what's going on, I'll move/reassign this bug as appropriate.
Comment 2 Mark Holmquist 2012-12-19 20:56:15 UTC
I believe this ties in directly to what Gabriel is doing, so I'll add him and we can have a big bugzilla CCing party.
Comment 3 Gabriel Wicke 2013-01-04 23:52:01 UTC
Likely fixed by the DOM diffing functionality that landed in https://gerrit.wikimedia.org/r/#/c/41816/. Barring bugs, we now no longer depend on change markers for selective serialization to work.
Comment 4 Gabriel Wicke 2013-01-04 23:52:59 UTC
(Needs verification with VE)
Comment 5 Gabriel Wicke 2013-01-25 19:45:54 UTC
A few more selser fixes later this should now be fixed. Repeating the test case above certainly suggests it works, so please reopen if there still are issues.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links