Last modified: 2013-06-14 00:17:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45082, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43082 - VisualEditor: Race condition between "Beginning of Line" and "New Line" operations
VisualEditor: Race condition between "Beginning of Line" and "New Line" opera...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-06-20
Assigned To: Inez Korczyński
:
Depends on:
Blocks: 48426
  Show dependency treegraph
 
Reported: 2012-12-13 18:11 UTC by Dan Barrett
Modified: 2013-06-14 00:17 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Barrett 2012-12-13 18:11:35 UTC
Here is normal behavior:

1. In VisualEditor, type a line of text.
2. Position your cursor at the beginning of that line.
3. Press the Home key on your keyboard, to move the cursor to the beginning of the line.
4. Wait a moment.
5. Press Enter, and the current text is pushed downward one line. This is correct and expected.

Here is the buggy behavior:

1. In VisualEditor, type a line of text.
2. Position your cursor at the beginning of that line.
3. VERY QUICKLY, press the Home key followed by the Enter key.
4. The cursor moves down one line, so it is positioned below the line of text. The text did not move. This is incorrect behavior. The line of text should have been pushed downward.
Comment 1 Dan Barrett 2012-12-13 18:12:26 UTC
Crap... I made a mistake in my report.

In line (2) of both examples, change "beginning of the line" to "end of the line." The cursor needs to be at the END of the line.
Comment 2 Roan Kattouw 2012-12-15 08:07:28 UTC
Sounds like a polling issue. "Very quickly" probably means "before the polling loop gets a chance to run"; it runs every 200ms.
Comment 3 Inez Korczyński 2013-06-12 01:35:14 UTC
This issue is not browser specific.
Comment 4 Inez Korczyński 2013-06-12 01:58:18 UTC
I've just created a test that covers this problem: https://github.com/inez/VE-tests/commit/4c1a444b207b37f90dc5d5ce969b5af00ee893ef (solution still not pushed).
Comment 5 Gerrit Notification Bot 2013-06-12 22:34:29 UTC
Related URL: https://gerrit.wikimedia.org/r/68300 (Gerrit Change I35c892581943057acbf9ddd638576e998cc82c1a)
Comment 6 Gerrit Notification Bot 2013-06-14 00:16:53 UTC
https://gerrit.wikimedia.org/r/68300 (Gerrit Change I35c892581943057acbf9ddd638576e998cc82c1a) | change APPROVED and MERGED [by jenkins-bot]
Comment 7 James Forrester 2013-06-14 00:17:55 UTC
Fixed and will go out with wmf8, from Thursday 20 June.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links