Last modified: 2013-05-03 01:22:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45063, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43063 - VisualEditor: Suppress "Web link" section in link inspector suggestion list if a wiki page link already exists
VisualEditor: Suppress "Web link" section in link inspector suggestion list i...
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-13 11:26 UTC by Gregor Hagedorn
Modified: 2013-05-03 01:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gregor Hagedorn 2012-12-13 11:26:14 UTC
Present situation: the Visual Editor, when clicking on an existing Wiki-Link, provides the chain-link icon which in turn opens a dialogue which contains a pick list. In the pick list two sections exist: "Existing page" (value e.g. "Pretoria") and "Web link" (e.g. "http://Pretoria"). 

The present dialogue is good enough for creating new links. However, for existing links it is somewhat confusing to offer a nonsense http:// link as an equally valid alternative to an existing or previously confirmed wiki page.

I suggest to keep the present behaviour for new links, but for existing wiki-page-links suppress the "web link" part of the pick list. It will still be possible to enter URLs directly in the dialogue box, the enhancement is only about suppressing it in the pick list.
Comment 1 James Forrester 2012-12-13 21:42:56 UTC
Not convinced that this is correct; yes, you /can/ have a valid page at a web site, but still want to link to the external one. For the most trivial example, "amazon.com" is both an article (on enwiki) and a valid external link. Therefore I'm minded to WONTFIX this.

Also, I'd note that there are timing issues (as the list is created before the suggestions are returned), but those are minor.
Comment 2 Gregor Hagedorn 2012-12-13 21:57:37 UTC
I am not proposing ANY changes to creating a new link. So when you mark the text wikipedia.org, yes you should be provided with page and the url in the picklist.

My suggestion is about the confusion that occurs when the link already exists and already points to an internal page. I believe that then the chance that users want to validly change it to an external http URL are very small and not worth the confusion. The enhancement is about avoiding visual clutter and avoiding accidental mis-selections. And in those cases where you do want to change an external link to an internal one: you can still do it, only not with the pick list.

I am not sure I understand the timing issues you mention, since the web page suggestions are always non-sense suggestions, just prefixing the text with http, so it seems easily suppressible. The ajax responsible for possible pages is a different story, but the visibility of that is not under discussion.
Comment 3 James Forrester 2013-05-03 01:21:16 UTC
This refers to behaviour that has now changed such that this is no longer actionable, so marking as INVALID.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links