Last modified: 2013-02-24 23:30:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45023, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43023 - VisualEditor: Handling of double click when preference "Edit pages on double click" is active
VisualEditor: Handling of double click when preference "Edit pages on double ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Low minor
: VE-deploy-2013-03-04
Assigned To: Krinkle
:
Depends on: 43052
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-12 17:27 UTC by Gregor Hagedorn
Modified: 2013-02-24 23:30 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gregor Hagedorn 2012-12-12 17:27:26 UTC
When using the VisualEditor and having the Preference "Edit pages on double click (requires JavaScript)" on, the Editor is stopped as soon as one tries to select a word  (= double click)or paragraph (= triple click). The javascript for "Edit pages on double click (requires JavaScript)" needs to be modified to check whether in VisualEditor mode or not (all works ok when in normal editing mode.
Comment 1 James Forrester 2012-12-12 20:40:07 UTC
Immediate solution is to suppress the JS when VE is active, but not when in read mode.

Longer-term, this should be refactored so that users have a "default" editor, and this kind of thing triggers whichever one you've chosen.
Comment 2 Krinkle 2012-12-13 05:13:50 UTC
The surface should just bind a click handler and prevent the event from bubbling up to the handler that mediawiki.action.view.dblClickEdit attaches to $content.
Comment 3 James Forrester 2013-01-17 22:20:49 UTC
Bumping; didn't make it to 2013-01-16.
Comment 4 Krinkle 2013-02-24 23:30:40 UTC
This has been fixed by Ie8a35700bc9e in mediawiki core.

In the current configuration however out tabLayout is in "add" more (when this bug was reported, we were still in "replace" mode).

In "add" mode we add an extra tab for "VisualEditor", so the original "Edit" is still there, which is the default. And double-clicking in the content area will (as it should) trigger the original editor.

If/when we enable the "replace" mode again, since this bug is fixed, double-clicking will trigger VisualEditor as expected.

So, although it can't be seen right now, as the feature is not activated right now, this bug as been fixed.

To verify, edit ve.init.mw.ViewPageTarget.js and set `this.tabLayout = "replace";`.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links