Last modified: 2014-01-10 03:42:18 UTC
Right now UploadWizard supports individual photo URLs and photoset URLs. It would be good to add support for photostream URLs, group URLs, etc. Each of these use a different API method in Flickr, so we would need to customize the code for each.
Related comment https://bugzilla.wikimedia.org/show_bug.cgi?id=28731#c13
(In reply to comment #1) > Related comment https://bugzilla.wikimedia.org/show_bug.cgi?id=28731#c13 Adding them here directly for convenience: * user collections (groups of albums (sets), potentially nested) http://www.flickr.com/photos/USER_ID/collections/COLLECTION_ID/ * user photostreams http://www.flickr.com/photos/USERID/ * group pools http://www.flickr.com/groups/FOO/pool/ and http://www.flickr.com/groups/FOO/pool/USERID/ * user galleries (albums of photos by many people, curated by a user) http://www.flickr.com/photos/USER_ID/galleries/GALLERY_ID/ * user favorites http://www.flickr.com/photos/USERID/favorites/
Would it be fair to call this an easy bug? It seems like it would be pretty simple to copy the handling code that exists and adapt it to each endpoint. Confirm, deny, or whatever, it would be cool to have extra easy things for new developers (we only have two or three right now).
I think this is going to be easy, anyways I am also ready to help with this.
I would like to give it a try. Where's the existing Flickr-related code (i.e. what files need to be edited)?
(In reply to comment #5) > I would like to give it a try. Where's the existing Flickr-related code (i.e. > what files need to be edited)? Mostly under mediawiki/extensions/UploadWizard/resources/mw.FlickrChecker.js in gerrit.wikimedia.org (see http://www.mediawiki.org/wiki/Gerrit ) plus general settings in mediawiki/extensions/UploadWizard/UploadWizard.config.php
just tried out adding support for gallery urls, will add other urls soon https://gerrit.wikimedia.org/r/#/c/54897/
Tags would also be useful: https://secure.flickr.com/photos/USER/tags/TAG/
(In reply to comment #3) > It seems like it would be pretty > simple to copy the handling code that exists and adapt it to each endpoint. (In reply to comment #4) > I think this is going to be easy, anyways I am also ready to help with this. Thanks Mark and Nischay, let's add it as GCI task. :)
Task created. Thank you for proposing GCI tasks!
Change 103967 had a related patch set uploaded by Mayankmadan: Adding support for more types of flickr URLs https://gerrit.wikimedia.org/r/103967
Change 103967 abandoned by Mayankmadan: Adding support for more types of flickr URLs Reason: Not working on this anymore https://gerrit.wikimedia.org/r/103967
Change 105393 had a related patch set uploaded by M4tx: Add support for more Flickr URLs https://gerrit.wikimedia.org/r/105393
I uploaded the patch. It wasn't so simple to implement the feature, though :) I wouldn't call it "easy" task; but maybe I just have insufficient knowledge...
(In reply to comment #14) > I uploaded the patch. It wasn't so simple to implement the feature, though > :) I > wouldn't call it "easy" task; but maybe I just have insufficient knowledge... Wow, we've seen some serious work here indeed, great! Probably the URL types were considered normally "easy" to add each by itself, I agree that doing them all is another matter.
Change 105393 merged by jenkins-bot: Add support for more Flickr URLs https://gerrit.wikimedia.org/r/105393
Man, all of this in one GCI task? that is amazing. Yes, I thought that adding individual types wouldn't be hard (with help of course) Anyways closing this as RF
