Last modified: 2013-12-09 19:35:28 UTC
The message Donate-interface-error-msg in the donations interface extension contains a variable which could be a whole list of other messages. These other messages appear to have been deleted. Should donate-interface-error-msg also be deleted? The documentation for translators on this message is at http://translatewiki.net/w/i.php?title=MediaWiki:Donate_interface-error-msg/qqq&action=edit Is this also the place to ask for a general review of the other messages in the donation interface extension? Translators are currently working on the extension for the fundraiser.
(In reply to comment #0) > Is this also the place to ask for a general review of the other messages in > the donation interface extension? Translators are currently working on the > extension for the fundraiser. I don't think that anybody has time for this currently as it's the busiest time of the year (Fundraising campaign), but reviews are always welcome.
The fundraising team is on the fence about this one. From lack of super clear guidance from the i18n team about how to actually remove messages and our constant need for random translations we seem to err on the side of always keeping translations around. I know there is a a way to set priority languages in the translation plugin, but I am unaware of a way to 'deprecate', 'hide', or 'emphasize' messages for appropriate treatment. In regards to the donate_interface-error-msg string -- unfortunately no, they weren't deleted. They're straight substations in the code (which is the real bug here). I believe the plan is still for non English language fundraising to start in April -- so yes there will be time for a review of the i18n files amongst other things.
Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.
All of the messages mentioned above are currently in use as far as I can see. I think that they shouldn't be removed.
(In reply to comment #4) > All of the messages mentioned above are currently in use as far as I can > see. I > think that they shouldn't be removed. Used where?
(In reply to comment #5) > (In reply to comment #4) > > All of the messages mentioned above are currently in use as far as I can > > see. I > > think that they shouldn't be removed. > > Used where? Donate interface-error-msg is used in DataValidator::getErrorMessage()[1]. [1]: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FDonationInterface.git/1c964dc8d6a75494a8d0b8e18cecdd41601ef927/gateway_common%2FDataValidator.php#L191
