Last modified: 2014-04-22 20:22:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44774, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42774 - [Regression] wikibugs no longer reports user name for NEW bugs
[Regression] wikibugs no longer reports user name for NEW bugs
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
wikibugs IRC bot (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 42852 43119 (view as bug list)
Depends on: 59076
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-06 13:36 UTC by Liangent
Modified: 2014-04-22 20:22 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2012-12-06 13:36:49 UTC
Not sure whether it worked before upgrading.

My name is not listed correctly in this line:

<wikibugs> (NEW) {{[[a]]}} is not parsed correctly - https://bugzilla.wikimedia.org/42773 normal; Parsoid: General; ()
Comment 1 Andre Klapper 2012-12-06 14:07:06 UTC
I don't see how that is a Bugzilla bug and not a wikibugs problem. :)
Comment 2 Andre Klapper 2012-12-06 14:09:23 UTC
Dup of bug 18831 comment 17?
In case this is an issue with Bugzilla code: I don't plan to fix it if it requires changing upstream code.
Comment 3 Alex Monk 2012-12-06 17:37:14 UTC
As far as I can tell, the name is missing for every new bug since the 4.2.4 upgrade.
Comment 4 Liangent 2012-12-07 21:46:30 UTC
(In reply to comment #3)
> As far as I can tell, the name is missing for every new bug since the 4.2.4
> upgrade.

You're right.
Comment 5 Alex Monk 2012-12-08 13:12:43 UTC
*** Bug 42852 has been marked as a duplicate of this bug. ***
Comment 6 Antoine "hashar" Musso (WMF) 2012-12-08 20:17:46 UTC
From bug 42852 : 

The wikibugs perl script does not handle multi part mime message and ends up
without any email body to parse.

Additionally, the field name, we used to find out who did the action, has changed from ReportedBy: to Reporter:.
Comment 7 MZMcBride 2012-12-11 23:41:41 UTC
(In reply to comment #6)
> The wikibugs perl script does not handle multi part mime message and ends up
> without any email body to parse.

I'm not sure this is accurate. I would think that if the bot were now receiving HTML e-mails, the parsing would've broken much more severely.

And, in any case, wouldn't it simply be a matter of logging in to the wikibugs-l Bugzilla account and toggling its e-mail user preference?

> Additionally, the field name, we used to find out who did the action, has
> changed from ReportedBy: to Reporter:.

This is probably the root cause of this bug. The bug summary has been recently updated to blame HTML e-mail, but I suspect the new bug summary is simply wrong.
Comment 8 Antoine "hashar" Musso (WMF) 2012-12-12 07:50:17 UTC
My assumption comes from reading the wikibugs perl script and we indeed need to fix both issues. To rephrase it:

The HTML mails comes with both a text and a HTML version which are encapsulated using MIME. The script does not support MIME and can not see the mail content.  Once that has been fixed, a field name has been changed and will need to be changed too.
Comment 9 Andre Klapper 2012-12-12 12:20:02 UTC
Switching the wikibugs-l@ account to plain text is easily possible, but I am not subscribed to wikibugs-l@lists.wikimedia.org so I have no idea who is interested and who isn't in keeping bugmail as plain text instead of HTML. On wikitech-l@ it sounded like a majority prefers HTML.
Comment 10 Danny B. 2012-12-14 02:01:09 UTC
Wikibugs *is* receiving plaintext mails from wikibugs-l.
Comment 11 Kunal Mehta (Legoktm) 2012-12-14 10:11:05 UTC
*** Bug 43119 has been marked as a duplicate of this bug. ***
Comment 12 Bartosz Dziewoński 2013-01-16 18:21:31 UTC
gerrit change I0e785f34 by AzaToth (Carl Fürstenberg) should fix this.
Comment 13 Bartosz Dziewoński 2013-01-17 23:35:50 UTC
Change is merged, but deployment is on hold. It has something to do with wikibugs not yet being fully git-compliant.
Comment 14 Carl Fürstenberg 2013-01-17 23:38:43 UTC
(In reply to comment #13)
> Change is merged, but deployment is on hold. It has something to do with
> wikibugs not yet being fully git-compliant.

Afaik, it's two things,

1. Change I0dab6f52 was never merged, which commit 60dd706256cebe656790eac93b269621b958ed92 refers to
2. mchenry has a too old copy of git, unable to clone current git repos (must be really old then....)
Comment 15 Andre Klapper 2013-01-18 09:23:27 UTC
(In reply to comment #13)
> Change is merged, but deployment is on hold. It has something to do with
> wikibugs not yet being fully git-compliant.

Requires https://gerrit.wikimedia.org/r/#/c/44454/
Comment 16 Krinkle 2013-02-14 09:11:34 UTC
What's the status on this? Which change in gerrit is the one that fixes this bug in wikibugs? The ones I see linked here have already been merged.
Comment 17 Antoine "hashar" Musso (WMF) 2013-02-14 10:01:39 UTC
The overal status is that Wikibugs sucks by design. The culprits are:

- use the perl language (we prefer php / python)
- badly written code
- lack of unit tests
- lack of integration tests
- runs directly on the mail server
- require ops to do anything on it

Petr Bena wrote another bot that consume RSS feed, that might be a slightly better design.  That bot is running on a labs instance as far as I know.

What we would need to do is startup a proper project with someone being in charge of listing the product requirement. Then write down some technical specifications and have a virtual team to start implementing them.

Ideally Bugzilla would offer an easily parseable feeds of its events and some to be written python script would consume the feed on the Bugzilla server to generate the notifications.

Overall I think wikibugs is considered very low priority given the amount of stuff we already have to implement / unbreak whatever.

I am not volunteering :-)
Comment 18 MZMcBride 2013-02-14 10:07:38 UTC
(In reply to comment #17)
> What we would need to do is startup a proper project with someone being in
> charge of listing the product requirement. Then write down some technical
> specifications and have a virtual team to start implementing them.
> 
> Ideally Bugzilla would offer an easily parseable feeds of its events and some
> to be written python script would consume the feed on the Bugzilla server to
> generate the notifications.

Related: bug 40970, and more specifically, bug 40970 comment 4.
Comment 19 Peter Bena 2013-02-14 10:50:12 UTC
wm-bot is written in c#, I don't really understand what you need, but wm-bot is already open source and already can be maintained by anyone who volunteers. Only problem I see is that bugzilla doesn't provide good machine parseable output of its events. Should there be any plugin for bugzilla that enables that, we should install it.

Regarding

- lack of unit tests
- lack of integration tests

I have no idea what you mean. If you need any other feed, it's no problem, wm-bot is very extendable - right now everything is implemented as plugins to a very lightweight and fast core
Comment 20 Antoine "hashar" Musso (WMF) 2013-02-14 21:44:31 UTC
Peter > I was refering to the wikibugs perl script, not your wm-bot C# tool :-]
Comment 21 Tim Landscheidt 2013-08-20 02:18:59 UTC
In reply to comment #16)
> What's the status on this? Which change in gerrit is the one that fixes this
> bug in wikibugs? The ones I see linked here have already been merged.

Agreed, and thus changing bug status.

For what it's worth, if I clone wikibugs on my local machine and run it on a NEW bug mail, it reports the reporter as "(tim)" in my case, while the deployed wikibugs says "()".  So maybe I am doing something wrong (or right?), or the deployment process is faulty.

Could some ops please verify:

- what script is called according to the exim config on mchenry, and
- what the MD5/SHA1/whatever of the script /as/ /deployed/ is?
Comment 22 Antoine "hashar" Musso (WMF) 2013-08-27 08:46:33 UTC
Tim, this is already fixed.  I described the possible root causes in Comment #6:

- wikibugs not support MIME message: turns out to not be an issue since it receives plain text message
- Reporter: field changed to ReportedBy: . That has been fixed by Carl in https://gerrit.wikimedia.org/r/#/c/44094/

So on your local machine you get a fixed up version.  What needs to be done is to get the production version to be refreshed by ops and have make sure it is still working.
Comment 23 Tim Landscheidt 2014-02-05 17:32:39 UTC
(In reply to comment #21)
> [...]

> Could some ops please verify:

> - what script is called according to the exim config on mchenry, and
> - what the MD5/SHA1/whatever of the script /as/ /deployed/ is?

Any news on this or the bug in general?  The symptoms still appear in #mediawiki:

| [00:55:21] <wikibugs>	 (NEW) CirrusSearch: Can't reindex commons.... - https://bugzilla.wikimedia.org/60854 normal; MediaWiki extensions: CirrusSearch; ()
Comment 24 Antoine "hashar" Musso (WMF) 2014-02-05 20:31:58 UTC
Tim Landscheidt wrote:
> Any news on this or the bug in general? 

See Comment #17 (ie: need to redesign wikibugs to no more be a hook on the mail server)
Comment 25 Tim Landscheidt 2014-02-05 20:53:51 UTC
(In reply to comment #24)
> > Any news on this or the bug in general? 

> See Comment #17 (ie: need to redesign wikibugs to no more be a hook on the
> mail
> server)

I assume it's a *lot* easier to have someone check/deploy a working version of wikibugs than to rewrite it from scratch :-).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links