Last modified: 2014-05-04 12:01:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 42527 - Wikisources transcluded <noinclude> tags broken in labelled section transclusions through Proofread Page
Wikisources transcluded <noinclude> tags broken in labelled section transclu...
Product: MediaWiki extensions
Classification: Unclassified
LabeledSectionTransclusion (Other open bugs)
All All
: Highest critical (vote)
: ---
Assigned To: Merlijn van Deen (test)
: code-update-regression
Depends on:
Blocks: Wikisource
  Show dependency treegraph
Reported: 2012-11-29 03:55 UTC by billinghurst
Modified: 2014-05-04 12:01 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Parser testcase (366 bytes, text/plain)
2012-11-29 09:58 UTC, Merlijn van Deen (test)

Description billinghurst 2012-11-29 03:55:11 UTC
With the upgrade to 1.20wmf5, transcluded pages that have an LST section (through Proofread Page) now do not drop the <noinclude>'d header and footer within the sections that are transcluded (starting or terminating transclusions).

Exhibit 1,_George_(1790-1853)_(DNB00)

I am guessing that it is in #LST rather than something in [[mw:Extension:Proofread Page]].  It may be the latter!

Where the transclusion is of a section within a page it works fine

Exhibit 2,_George_(1754-1808)_(DNB00)

Where there is full transclusion of consecutive pages, then the noinclude tags work as expected.  See difference between exhibits 3 and 4 where I have shifted the partial transclusion to later pages and how the problem just occurs on the terminating page which has the transclusion

Exhibit 3

Exhibit 4

I would like to ask to a rollback to previous version "1.20 wmf 4" until this issue is resolved.  We have probably between ten to one hundred thousand pages that will be affected by this bug at enWS, and this will be Wikisource wide

Alternatively we need to get the problem resolve really really quickly
Comment 1 Merlijn van Deen (test) 2012-11-29 08:50:25 UTC
Minimal test case:

where the first is normal transclusion, the second transclusion using

{{#lst:Page:Dictionary of National Biography volume 23.djvu/109||Gregory, James (1753-1821)}}

I'll try to create an automatic test for this, to confirm whether this regression was introduced by the recent LST changes or not.
Comment 2 billinghurst 2012-11-29 08:58:24 UTC
And using ProofreadPage terminology
Comment 3 Merlijn van Deen (test) 2012-11-29 09:58:44 UTC
Created attachment 11432 [details]
Parser testcase

Confirmed to be caused by See attachment for parser tests.
Comment 4 Merlijn van Deen (test) 2012-11-29 11:31:19 UTC
Comment 5 Tpt 2012-11-29 20:08:38 UTC
Fixed. Patch deployed on Wikisource. Thanks to Merlijn, demon and Rob. A purge (?action=purge) is needed in order to clean the affected pages.
Comment 6 Gerrit Notification Bot 2014-05-04 12:01:53 UTC
Change 37313 merged by jenkins-bot:
Bug 42527 - <noinclude> tags broken in LST

Note You need to log in before you can comment on or make changes to this bug.