Last modified: 2014-05-04 12:01:53 UTC
With the upgrade to 1.20wmf5, transcluded pages that have an LST section (through Proofread Page) now do not drop the <noinclude>'d header and footer within the sections that are transcluded (starting or terminating transclusions). Exhibit 1 https://en.wikisource.org/wiki/Gregory,_George_(1790-1853)_(DNB00) I am guessing that it is in #LST rather than something in [[mw:Extension:Proofread Page]]. It may be the latter! Where the transclusion is of a section within a page it works fine Exhibit 2 https://en.wikisource.org/wiki/Gregory,_George_(1754-1808)_(DNB00) Where there is full transclusion of consecutive pages, then the noinclude tags work as expected. See difference between exhibits 3 and 4 where I have shifted the partial transclusion to later pages and how the problem just occurs on the terminating page which has the transclusion Exhibit 3 https://en.wikisource.org/w/index.php?title=Wikisource:Sandbox&oldid=4153465 Exhibit 4 https://en.wikisource.org/w/index.php?title=Wikisource:Sandbox&oldid=4153467 I would like to ask to a rollback to previous version "1.20 wmf 4" until this issue is resolved. We have probably between ten to one hundred thousand pages that will be affected by this bug at enWS, and this will be Wikisource wide Alternatively we need to get the problem resolve really really quickly
Minimal test case: https://en.wikisource.org/w/index.php?title=Wikisource:Sandbox&oldid=4153680 where the first is normal transclusion, the second transclusion using {{#lst:Page:Dictionary of National Biography volume 23.djvu/109||Gregory, James (1753-1821)}} I'll try to create an automatic test for this, to confirm whether this regression was introduced by the recent LST changes or not.
And using ProofreadPage terminology https://en.wikisource.org/w/index.php?title=Wikisource:Sandbox&oldid=4153682
Created attachment 11432 [details] Parser testcase Confirmed to be caused by https://gerrit.wikimedia.org/r/#/c/31330/. See attachment for parser tests.
Patch: https://gerrit.wikimedia.org/r/#/c/35879/
Fixed. Patch deployed on Wikisource. Thanks to Merlijn, demon and Rob. A purge (?action=purge) is needed in order to clean the affected pages.
Change 37313 merged by jenkins-bot: Bug 42527 - <noinclude> tags broken in LST https://gerrit.wikimedia.org/r/37313
