Last modified: 2013-04-12 22:55:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44419, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42419 - Trailing slashes in Gerrit URLs are kind of nasty
Trailing slashes in Gerrit URLs are kind of nasty
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
: 44928 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-24 23:22 UTC by MZMcBride
Modified: 2013-04-12 22:55 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2012-11-24 23:22:34 UTC 
Works:

* https://gerrit.wikimedia.org/r/#/c/12345/
* https://gerrit.wikimedia.org/r/#/c/12345
* https://gerrit.wikimedia.org/r/12345

Does not work, but really ought to:

* https://gerrit.wikimedia.org/r/12345/

Basically, if you try to manually shorten a URL from /r/#/c/ syntax to just /r/ syntax, you must remember that you cannot have a trailing slash. Including a trailing slash produces a HTTP 404 not found error.

I believe that <https://gerrit.wikimedia.org/r/12345> and <https://gerrit.wikimedia.org/r/12345/> both really ought to work.
Comment 1 Chad H. 2012-12-04 19:39:46 UTC 
Definitely an upstream issue. Probably just needs some tweaking in Dispatcher, but haven't looked yet.
Comment 2 Antoine "hashar" Musso (WMF) 2013-02-13 11:35:32 UTC 
*** Bug 44928 has been marked as a duplicate of this bug. ***
Comment 3 christian 2013-03-19 10:20:20 UTC 
Fix submitted upstream at
https://gerrit-review.googlesource.com/#/c/43632/
Comment 4 Chad H. 2013-04-12 16:27:12 UTC 
This was merged upstream and has been deployed. All the example URLs WFM now.
Comment 5 MZMcBride 2013-04-12 22:55:12 UTC 
Sweet. :-)  Thanks, everyone!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links