Last modified: 2014-10-07 05:33:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44345, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42345 - Blocks from AbuseFilter show up as performed from the target's IP address in Checkuser
Blocks from AbuseFilter show up as performed from the target's IP address in ...
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks: user-127.0.0.1
  Show dependency treegraph
 
Reported: 2012-11-22 01:49 UTC by Snowolf
Modified: 2014-10-07 05:33 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Snowolf 2012-11-22 01:49:27 UTC
Blocks performed by the AbuseFilter show up in the Checkuser as having been performed thru the target's IP address, hence it appears as if the IP had been used by more than one user, one being the actual user and the other being AbuseFilter blocking it.

This causes some confusions and several times I've performed the additional check on the IP trying to figure out who else used it.
Comment 1 Gerrit Notification Bot 2013-10-26 04:38:09 UTC
Change 92050 had a related patch set uploaded by Legoktm:
Allow extensions to override the IP address

https://gerrit.wikimedia.org/r/92050
Comment 2 Gerrit Notification Bot 2013-10-26 04:39:25 UTC
Change 92051 had a related patch set uploaded by Legoktm:
Override the IP for the filter user in CheckUser data

https://gerrit.wikimedia.org/r/92051
Comment 3 Gerrit Notification Bot 2013-10-27 14:04:52 UTC
Change 92179 had a related patch set uploaded by saper:
Allow robotic Users to determine their IP address

https://gerrit.wikimedia.org/r/92179
Comment 4 Marcin Cieślak 2013-10-27 20:49:37 UTC
I did some checks here and the problem is thet a whole original WebRequest is re-used for logging.

Even if we force the AbuseFilter to give different IP address, for example user agent will be taken from the original request.
Comment 5 Gerrit Notification Bot 2013-10-27 21:38:01 UTC
Change 92252 had a related patch set uploaded by saper:
Introduce AbuseFilterUser

https://gerrit.wikimedia.org/r/92252
Comment 6 Gerrit Notification Bot 2013-10-28 18:20:12 UTC
Change 92179 abandoned by saper:
Allow robotic Users to determine their IP address

Reason:
as per review

https://gerrit.wikimedia.org/r/92179
Comment 7 Gerrit Notification Bot 2013-10-28 18:21:09 UTC
Change 92252 abandoned by saper:
Introduce AbuseFilterUser

Reason:
Thank you, closing per code review.

https://gerrit.wikimedia.org/r/92252
Comment 8 John Mark Vandenberg 2014-10-07 05:33:16 UTC
status update: two of the patches have been abandoned, but this one is still under review

https://gerrit.wikimedia.org/r/#/c/92051/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links