Last modified: 2013-04-22 16:14:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44311, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42311 - UW flickr uploader disappears completely upon input of invalid URL
UW flickr uploader disappears completely upon input of invalid URL
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch-need-review
Depends on:
Blocks: 43450
  Show dependency tree / graph
 
Reported: 2012-11-20 22:32 UTC by Lupo
Modified: 2013-04-22 16:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Lupo 2012-11-20 22:32:17 UTC 
Sample URL:

http://www.flickr.com/photos/bensutherland/308795905

(This is invalid, it has an extra "5" at the end.)

The input field for the flickr URL disappears. No error message, no nothing. (Using FF 16.0.2 on Mac OS X 10.7.5)
Comment 1 Nischay Nahata 2012-11-22 06:43:18 UTC 
This happens because this URL passes our regex pattern. Don't think we can identify such invalid urls in regex.. (This one might actually become a valid id in future).

Instead if the fetching of the photo fails the error dialog should appear.
Comment 2 Nischay Nahata 2012-11-22 08:10:06 UTC 
Added the missing else statement
https://gerrit.wikimedia.org/r/#/c/34691/
Comment 3 Ryan Kaldari 2012-11-23 02:42:46 UTC 
Merged.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links