Last modified: 2013-08-08 10:39:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44193, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42193 - Diffs in Opera and monobook are not colored
Diffs in Opera and monobook are not colored
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
: code-update-regression
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2012-11-16 12:32 UTC by JAn Dudík
Modified: 2013-08-08 10:39 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Opera and monobook (85.63 KB, image/jpeg)
2012-11-16 12:32 UTC, JAn Dudík
Details
Opera and vector (94.13 KB, image/jpeg)
2012-11-16 12:33 UTC, JAn Dudík
Details
Chrome and monobook (98.88 KB, image/jpeg)
2012-11-16 12:34 UTC, JAn Dudík
Details
Screenshot of diffs on cs.wikipedia.org with monobook in Opera on Windows. (363.75 KB, image/png)
2012-11-23 00:54 UTC, Krinkle
Details

Description JAn Dudík 2012-11-16 12:32:37 UTC
Created attachment 11371 [details]
Opera and monobook

Last about two days I have not colored diffs when using monobook skin and Opera browser.
In Chrome browser is all OK, in vector too.
I deletd my common.css,  but there was not anything.
Comment 1 JAn Dudík 2012-11-16 12:33:40 UTC
Created attachment 11372 [details]
Opera and vector
Comment 2 JAn Dudík 2012-11-16 12:34:00 UTC
Created attachment 11373 [details]
Chrome and monobook
Comment 3 Maggie Dennis 2012-11-16 12:38:34 UTC
I'm having similar issues in Chrome, but not Firefox, using Monobook. There are additional notes about it at the Village Pump, where it seems to be affecting a wide range of browsers. See http://en.wikipedia.org/wiki/Wikipedia:VPT#Style_sheet_changes
Comment 4 Andre Klapper 2012-11-16 15:15:35 UTC
(In reply to comment #0)
> Last about two days I have not colored diffs when using monobook skin and Opera
> browser.

http://cs.wikipedia.org/w/index.php?title=%C3%9Ast%C3%AD_nad_Labem&diff=9304488&oldid=9231215&useskin=monobook (the screenshot that you posted) works correctly for me in Firefox 16.0.2 (diffs are colored and have CSS).
And apart from the broken fundraising banner it also works fine in Opera 12.02 build 1578 here.

If regard to the timeframe, two days ago, 1.21wmf4 got deployed to several websites but not to any Wikipedias, and there have not been changes in Monobook either: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=history;f=skins/monobook;hb=HEAD

Mentioning CSS issues on IRC I was told that that "Peter did some bits apaches upgrades to 12.04 yesterday, so I'd suspect it is related to those". That might explain this and other problems mentioned in https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Missing_Gadgets_Tab or http://en.wikipedia.org/wiki/Wikipedia:VPT#Style_sheet_changes or bug 42170, maybe also bug 42163.
Comment 5 Derk-Jan Hartman 2012-11-19 09:35:35 UTC
To quote:

"Seems there have been a lot of people going "me too", and not many people looking at what is causing the problem. I looked into this a few hours ago when I first saw it happening. Since diff colours seemed to be the worst affected, I checked the HTML source to find the CSS for diff colours. For me, they come from bits.wikimedia.org. I loaded that page in my browser, and found it contained errors like "Can't connect to local MySQL server" followed by PHP stack traces, but no CSS. The error message was repeated several times, with a slightly different stack trace each time. Unfortunately, I didn't make a note of the exact error text at the time and I can't get the problem to happen again now... I'll post back if it happens again"

So sounds like the apache upgrades might have been the cause, letting stacktraces get stuck in cache.
Comment 6 JAn Dudík 2012-11-19 20:56:07 UTC
the problematic path is 

http://bits.wikimedia.org/cs.wikipedia.org/load.php?debug=false&lang=cs&modules=mediawiki.action.history.diff&only=styles&skin=monobook&*

I copied content to my monobook.css and now it works for me

Yesterday I tried to modify this path and without * on the end it worked, with * not.
Comment 7 Krinkle 2012-11-23 00:53:00 UTC
The screenshot you provided from Monobook + Opera, the entire page is blank. Seems like the file was not uploaded correctly, can you make another screenshot using this link? 

https://cs.wikipedia.org/w/index.php?title=P%C5%99emysl_Sobotka&curid=77694&diff=9332161&oldid=9289856&useskin=monobook

I tested this link in Opera 12.10 on Windows 7, and it was working fine for me.

What version of Opera and Windows do you have?
Comment 8 Krinkle 2012-11-23 00:54:25 UTC
Created attachment 11410 [details]
Screenshot of diffs on cs.wikipedia.org with monobook in Opera on Windows.
Comment 9 Andre Klapper 2013-04-02 20:04:29 UTC
JAn, is this still a problem? If yes, could you please answer the following questions?

(In reply to comment #7)
> The screenshot you provided from Monobook + Opera, the entire page is blank.
> Seems like the file was not uploaded correctly, can you make another
> screenshot using this link? 
> 
> What version of Opera and Windows do you have?
Comment 10 Derk-Jan Hartman 2013-04-21 13:34:15 UTC
@Andre, this was all solved after several days. The interesting question is, was the root cause solved/mitigated:

"Can't connect to local MySQL server" being cached for upto 30 days for CSS and JS created by RL on bits.
Comment 11 Bartosz Dziewoński 2013-04-21 13:38:36 UTC
I'll mark it as WORKSFORME then.

I can't give you the commit ID now, but I'm pretty sure the caching behavior has been fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links