Last modified: 2014-03-26 18:34:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44139, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42139 - VisualEditor: There is not preview of edit summaries (which are wikitext) - show it in the wikitext diff?
VisualEditor: There is not preview of edit summaries (which are wikitext) - s...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-02-20
Assigned To: Alex Monk
:
: 51125 53729 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-15 05:34 UTC by MZMcBride
Modified: 2014-03-26 18:34 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2012-11-15 05:34:25 UTC 
The current VisualEditor interface has a "Save page" dialog box with an edit summary input field. However, this edit summary input field accepts wikitext, but has no preview feature for what the rendered wikitext will look like. This is a regression from the standard (non-VisualEditor) interface.

Roan said that there be a mini-editor or mini-parser or something stuck in the edit summary area at some point.
Comment 1 James Forrester 2012-11-15 22:20:28 UTC 
As Max says, to be resolved by the dialog being a mini-VE surface.
Comment 2 James Forrester 2013-07-10 18:27:49 UTC 
*** Bug 51125 has been marked as a duplicate of this bug. ***
Comment 3 James Forrester 2013-07-10 18:30:03 UTC 
Per bug 51125 (which has been merged into this one), we should show the edit summary if provided in the "Review your changes" tab
Comment 4 Chris McKenna 2013-07-10 19:07:04 UTC 
User:Elizium23 at en.wp comments that the current save dialog "permits entry of an edit summary with newlines, however, no newlines are preserved in the edit summary when it is saved to the Wiki. This is confusing, because I just used a WYSIWYG editor, but what I see in the edit summary is not what I get."

While, AIUI, the current dialog is only temporary the issue of newlines (and presumably bold, italic, etc) will be applicable to the new "surface" unless that doesn't permit these features or edit summaries are upgraded to support them.
Comment 5 Chris McKenna 2013-09-30 12:54:19 UTC 
*** Bug 53729 has been marked as a duplicate of this bug. ***
Comment 6 Chris McKenna 2013-09-30 12:55:17 UTC 
From Bug 53729:
A De.WP user suggested to include a preview for the edit summary. Report:

https://de.wikipedia.org/w/index.php?title=Wikipedia:Technik/Text/Edit/VisualEditor/Beta2013-07&oldid=122207411#Vorschau_f.C3.BCr_Zusammenfassung_und_Quellen
Comment 7 Alex Monk 2014-02-10 14:33:31 UTC 
(In reply to comment #1)
> As Max says, to be resolved by the dialog being a mini-VE surface.

So this has been assigned to me but I think I need a few pointers. Firstly, where can I find the code for mini-surfaces?
Comment 8 James Forrester 2014-02-10 17:26:10 UTC 
To clarify, when the diff is shown ('Review your changes' dialog pane) we want to parse the entered summary and display it, probably above the diff.
Comment 9 Gerrit Notification Bot 2014-02-10 18:36:49 UTC 
Change 112490 had a related patch set uploaded by Alex Monk:
Show preview of edit summary in review screen

https://gerrit.wikimedia.org/r/112490
Comment 10 Gerrit Notification Bot 2014-02-19 23:07:21 UTC 
Change 112490 merged by jenkins-bot:
Show preview of edit summary in review screen

https://gerrit.wikimedia.org/r/112490
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links