Last modified: 2013-04-25 11:53:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44054, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42054 - ClickTracking: Don't use deprecated wfGenerateToken()
ClickTracking: Don't use deprecated wfGenerateToken()
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
ClickTracking (Other open bugs)
unspecified
All All
: Lowest trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2012-11-12 21:55 UTC by Alex Monk
Modified: 2013-04-25 11:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Alex Monk 2012-11-12 21:55:36 UTC 
I've been seeing this notice on my dev/test wiki:

Deprecated:  Use of wfGenerateToken was deprecated in MediaWiki 1.20. [Called from ClickTrackingHooks::makeGlobalVariablesScript in /var/www/MediaWiki/Git/extensions/ClickTracking/ClickTracking.hooks.php at line 77] in /var/www/MediaWiki/Git/core/includes/debug/Debug.php on line 283

No idea how to correctly fix this, so I thought I'd put it here.
Comment 1 Daniel Friesen 2012-11-12 22:07:19 UTC 
"@deprecated since 1.20; Please use MWCryptRand for security purposes and wfRandomString for pesudo-random strings"

wfGenerateToken was an unacceptable mess. It was used both for security purposes and trivial pesudo-random tokens as well. It claimed to be cryptographically secure but it used nothing more than one or two insecure calls to mt_rand. 

So, MWCryptRand if you are making tokens that need to be secure; Session tokens, user tokens, email confirmation tokens, etc... basically anything where it's possible it might matter that someone else could guess it.
And a new function, wfRandomString for simple random semi-unique strings. Such as UNIQ ids like those used in the parser.
Comment 2 Andre Klapper 2013-04-12 11:11:28 UTC 
WONTFIX as per http://lists.wikimedia.org/pipermail/wikitech-l/2013-April/068359.html ?
Comment 3 Andre Klapper 2013-04-25 11:53:43 UTC 
I assume so.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links