Last modified: 2014-03-07 11:44:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43940, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41940 - Amiri font for Arab lacks italics and bold causing bad rendering
Amiri font for Arab lacks italics and bold causing bad rendering
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 53015 41359
  Show dependency treegraph
 
Reported: 2012-11-09 23:38 UTC by Nemo
Modified: 2014-03-07 11:44 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Font styles when Amiri font is selected (118.78 KB, image/png)
2013-03-22 11:13 UTC, Khaled Hosny
Details
Font styles when system font is selected (120.77 KB, image/png)
2013-03-22 11:14 UTC, Khaled Hosny
Details
Untested patch (1.09 KB, patch)
2014-01-11 00:52 UTC, Khaled Hosny
Details

Description Nemo 2012-11-09 23:38:07 UTC
Moved from bug 41359.
Attachment 11341 [details] shows current rendering on ar.wiki; attachment 11342 [details] the expected one.
Bug 41359 comment 22 also proposes an interpretation of the problem.
Comment 1 Khaled Hosny 2012-11-11 11:34:53 UTC
Any progress in this, the faux bold is really disturbing.
Comment 2 Andre Klapper 2012-11-11 12:07:16 UTC
(In reply to comment #1)
> Any progress in this, the faux bold is really disturbing.

Very likely NOT on a weekend within 36 hours after reporting the problem.
Comment 3 Khaled Hosny 2012-11-11 12:36:39 UTC
36 hours are too much if you are seeing this all the time, and it is not the week end here either :) So sorry for being so persistent, and please let me know if there is anything I can help with.
Comment 4 Santhosh Thottingal 2012-11-14 11:03:24 UTC
Patch here: gerrit I1200c746
Comment 5 Amir E. Aharoni 2012-11-20 20:55:42 UTC
Merged, waits for deployment.
Comment 6 Khaled Hosny 2012-11-30 06:44:04 UTC
Now on Arabic wikipedia all four styles have "local('Amiri')" in the @font-face declaration, as a result people who have the font locally installed are getting the regular font for all text styles (at least on Firefox 17).
Comment 7 Runa Bhattacharjee 2013-03-22 10:59:24 UTC
Hello, Can you please add a screenshot for the problem that you have been facing? Thanks.
Comment 8 Khaled Hosny 2013-03-22 11:13:48 UTC
Created attachment 11970 [details]
Font styles when Amiri font is selected
Comment 9 Khaled Hosny 2013-03-22 11:14:54 UTC
Created attachment 11971 [details]
Font styles when system font is selected
Comment 10 Santhosh Thottingal 2013-06-10 05:20:08 UTC
unassigning from me
Comment 11 Siebrand Mazeland 2013-12-19 19:45:13 UTC
ecreasing the impact. Font is not default.
Comment 12 Khaled Hosny 2014-01-10 23:57:05 UTC
Any chance of getting this fixed, the fix seems trivial as outlined in bug 41359, comment 22.
Comment 13 Khaled Hosny 2014-01-11 00:14:07 UTC
OK, after reading bug 41359, comment 22 again, I see why it wasn’t that helpful as it didn’t actually point to the real issue.

The problem is that all the four @font-face rules for Amiri has "local('Amiri')" which causes Firefox to use the regular font for all styles if the user has the font locally installed. The fix is to use "local('Amiri')", "local('Amiri Bold')", "local('Amiri Slanted')" and "local('Amiri Bold Slanted')" for regular, bold, italic and bold italic fonts, respectively.
Comment 14 Khaled Hosny 2014-01-11 00:26:51 UTC
Using Italic instead of Slanted also works, in case it simplifies things.
Comment 15 Khaled Hosny 2014-01-11 00:52:32 UTC
Created attachment 14288 [details]
Untested patch

I guess something like that should work, but I couldn’t test it (I fear it will need setting up local MediaWiki install which is not something I’ve done before).
Comment 16 Nemo 2014-01-11 08:11:31 UTC
(In reply to comment #15)
> Created attachment 14288 [details]
> Untested patch
> 
> I guess something like that should work, but I couldn’t test it (I fear it
> will
> need setting up local MediaWiki install which is not something I’ve done
> before).

Thank you! Please see [[mw:How to become a MediaWiki hacker]], particularly [[mw:MediaWiki-Vagrant]] to test locally and [[mw:Gerrit/Tutorial]] on how to send your patch to gerrit, to speed things up.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links