Last modified: 2014-11-18 18:07:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43466, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 41466 - Cannot recover from invalid token error


Summary:	Cannot recover from invalid token error

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal with 1 vote (vote)
Target Milestone:	---
Assigned To:	Krinkle

URL:
Whiteboard:	tux-fixed
Keywords:

Depends on:
Blocks:	48775 69314
	Show dependency tree / graph

Reported:	2012-10-28 09:27 UTC by Tisza Gergő
Modified:	2014-11-18 18:07 UTC (History)
CC List:	14 users (show)

See Also:	45766 9749
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tisza Gergő 2012-10-28 09:27:03 UTC

After getting an "Invalid token (badtoken)" error when saving a translation (probably due to timeout), the interface cannot recover: pressing the save button again will just repeat the same error message.

Comment 1 Niklas Laxström 2012-11-10 04:14:09 UTC

You need to refresh the page.

Comment 2 Tisza Gergő 2012-11-10 04:23:03 UTC

Of course, but you shouldn't have to; the script could request a new token without any user interaction.

Comment 3 Nemo 2013-09-09 05:58:18 UTC

*** Bug 48775 has been marked as a duplicate of this bug. ***

Comment 4 Matthew Flaschen 2013-11-21 08:40:58 UTC

This is a core issue.  See https://gerrit.wikimedia.org/r/#/c/83217/

Comment 5 Brad Jorsch 2013-11-21 14:51:59 UTC

Wrong component. As shown by your own gerrit change, the problem is in JavaScript and not the API.

Comment 6 Brad Jorsch 2013-11-21 14:52:34 UTC

(why do I always forget to uncheck that "reset assignee" box?)

Comment 7 Siebrand Mazeland 2013-12-08 10:14:41 UTC

Any of our JavaScript gurus have any ideas on how to make progress on this?

Comment 8 Tisza Gergő 2013-12-08 15:41:35 UTC

Won't I759739 fix this? It makes mw.api reload the token and retry on a badtoken error.

Comment 9 Matthew Flaschen 2013-12-10 21:42:28 UTC

Yes, I7597399ae72381a3b3253637ed4a6537c3fb1406 is meant to fix this.

Comment 10 Andre Klapper 2014-07-18 12:40:03 UTC

(In reply to Matthew Flaschen from comment #9)
> Yes, I7597399ae72381a3b3253637ed4a6537c3fb1406 is meant to fix this.

That patch was abandoned in favor of https://gerrit.wikimedia.org/r/#/c/111636/ for bug 34733 which was merged on 2014-04-04.

mflaschen: Can we close this report as RESOLVED FIXED?

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links