Last modified: 2012-12-16 20:34:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43342, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41342 - jquery.suggestions should cancel any active (async) fetches before it triggers another fetch
jquery.suggestions should cancel any active (async) fetches before it trigger...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
1.19
All All
: Normal normal (vote)
: 1.21.0 release
Assigned To: Krinkle
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks: 27411
  Show dependency treegraph
 
Reported: 2012-10-24 08:07 UTC by Derk-Jan Hartman
Modified: 2012-12-16 20:34 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2012-10-24 08:07:34 UTC
"I type in a search term, and one or more relevant items might appear, but when I move the cursor into it, often I get a different list. As an example, I typed "the beatles", and at first it showed items beginning with "the beatles", then it jumped to all items starting with "the be". This kind of thing happens on both home and work PC's....It started happening when the word "Search" started to appear in the search box, instead of normally being blank."

User is reportedly using IE8
Comment 1 Derk-Jan Hartman 2012-10-24 11:12:39 UTC
Important note, this is with the cologneblue skin.
Comment 2 Andre Klapper 2012-10-24 18:23:33 UTC
[Low prio as long as we don't know if newer versions / other browsers are also affected]
Comment 3 Bartosz Dziewoński 2012-10-24 18:26:40 UTC
Per bug 41349 search suggestions in CologneBlue are currently broken, there's a pending patchset linked on that bug.
Comment 4 Bartosz Dziewoński 2012-11-13 20:11:34 UTC
That other bug was fixed (ages ago, in fact). Does this still happen?
Comment 5 Bartosz Dziewoński 2012-11-21 17:26:15 UTC
So this is something completely different and I'm repurposing the bug.

Simply, Search Suggest suggestions are processed in the order API requests arrive, not in the order they're sent. So if you're on a lousy connection and type "wikipedia", 9 requests get sent (suggestions for "w", "wi", "wik", etc.), and they will not necessarily arrive in the same order.

Then you get the effect described above - suggestions for "wikipedia" flash briefly and then are replaced by suggestions for "wik", even though the bolding is correct.

The API has a requestid parameter, it should be used so we drop requests for suggestions older than the one currently displayed. A simple counter would suffice.

(One should test it using a debugging proxy like Fiddler.)
Comment 6 Bartosz Dziewoński 2012-11-24 16:47:48 UTC
I submitted Gerrit change #34972 to fix this issue (albeit in a slightly different way).
Comment 7 Krinkle 2012-12-16 20:34:43 UTC
(In reply to comment #6)
> I submitted Gerrit change #34972 to fix this issue.

Thanks, landed in master.

Change-Id: I880a61e5e45a64bea6d679ed160c4be3da085dfa

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links