Last modified: 2013-07-25 07:06:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 41321 - Comments with the string "Gerrit 2.5" should not link to Gerrit.
Comments with the string "Gerrit 2.5" should not link to Gerrit.
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Andre Klapper
:
Depends on:
Blocks: 35144
  Show dependency tree / graph
 
Reported: 2012-10-23 19:03 UTC by Rob Lanphier
Modified: 2013-07-25 07:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rob Lanphier 2012-10-23 19:03:24 UTC 
Currently, putting "G-errit 2.5" (minus the minus) in a comment causes a link to a Gerrit change id 2.  This is kinda dumb, since the odds of someone actually referring to https://gerrit.wikimedia.org/r/#/c/2 are almost zero.

Can we make the Gerrit regex in BZ a little less aggressive about linking to Gerrit?  I'd like to at least be able to refer to the next version of the software without my comments being mauled.
Comment 2 Andre Klapper 2012-11-17 00:34:13 UTC 
Assuming that Gerrit version 10 is not around the corner, 
    match => qr{\bgerrit(\ change(set)?)?\ ?\#?(\d+)}i,
should be replaced by
    match => qr{\bgerrit(\ change(set)?)?\ ?\#?(\d{2,})}i,
I'll cook up a Gerrit patch once my other one got in.
Comment 3 Andre Klapper 2012-11-29 01:25:35 UTC 
https://gerrit.wikimedia.org/r/#/c/35840/
Comment 4 Andre Klapper 2012-12-14 17:46:16 UTC 
https://rt.wikimedia.org/Ticket/Display.html?id=4125 for deployment.
Comment 5 Daniel Zahn 2012-12-17 17:50:08 UTC 
merged:

https://gerrit.wikimedia.org/r/#/c/35840/

applied on "4.2" dir:

https://gerrit.wikimedia.org/r/#/c/39068/

..and deployed in production
Comment 6 Andre Klapper 2012-12-17 20:52:59 UTC 
Daniel: Thanks, as usual!
Comment 7 Andre Klapper 2012-12-17 20:53:11 UTC 
Obviously it's working (see subject of this report) so also verifying.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links