Last modified: 2013-04-22 16:15:45 UTC
0.8390 27.8M Query sandwiki (865) (slave): UPDATE /* Threads::synchroniseArticleData Nike */ `bw_thread` SET thread_article_id = '2137195' WHERE (thread_article_namespace = '1198' AND thread_article_title = 'Technology/Page_display_title/sl') AND (NOT (thread_article_id = '2137195')) 0.8400 27.8M Query sandwiki (866) (slave): UPDATE /* Threads::synchroniseArticleData Nike */ `bw_thread` SET thread_article_namespace = '1198',thread_article_title = 'Technology/Page_display_title/sr-ec' WHERE (thread_article_id = '1972126') AND (NOT (thread_article_namespace = '1198' AND thread_article_title = 'Technology/Page_display_title/sr-ec')) It should not do any UPDATE calls on Title::isValidMoveOperation unconditionally, especially when the titles are not related to threads at all.
Gerrit change #29795, Gerrit change #29796
Query example for a moved test page[1]. 0.0759 11.2M Query sandbox (16) (slave): SELECT /* Threads::synchroniseArticleData Siebrand */ COUNT(*) FROM `thread` WHERE (thread_article_id = '7474') AND (NOT (thread_article_namespace = '2' AND thread_article_title = 'Siebrand/test2')) LIMIT 1 0.0762 11.2M Query sandbox (17) (slave): SELECT /* Threads::synchroniseArticleData Siebrand */ COUNT(*) FROM `thread` WHERE (thread_article_namespace = '2' AND thread_article_title = 'Siebrand/test2') AND (NOT (thread_article_id = '7474')) LIMIT 1 There are no update queries. [1] http://sandbox.translatewiki.net/w/i.php?title=User:Siebrand/test2
(In reply to comment #1) > Gerrit change #29795, Gerrit change #29796 Status Merged and Status Merged
Reopening. This is still the primary suspect of cause for bug 41138 which is still open.
This issue is fixed. There no longer are two update queries per moved page. Simply reopening this issue because bug 41138 isn't closed isn't helpful.
Thanks for your effort. What you did is surely an improvement, but. I'm sorry I didn't write the bug description accurately enough: It should not do any <del>UPDATE</del> calls on Title::isValidMoveOperation unconditionally, especially when the titles are not related to threads at all. You fixed the bug if read literally, but not the issue.
(In reply to comment #6) > Thanks for your effort. What you did is surely an improvement, but. > > I'm sorry I didn't write the bug description accurately enough: It should not > do any <del>UPDATE</del> calls on Title::isValidMoveOperation > unconditionally, especially when the titles are not related to threads at > all. > > You fixed the bug if read literally, but not the issue. I fixed the issue that was described. No more update queries are made unconditionally. The above is scope creep that is not needed inside of this issue. In comment 6, you're adding a new requirement that is outside of the scope of this issue (or even outside of my current interest as it's architectural). For all intents and purposes, this issue is closed and should remain closed. If you think that based on the fix made here, there is another issue, I think it's best to open a new issue.
(In reply to comment #7) > If you think that based on the fix made here, there is another issue, I think > it's best to open a new issue. This has already been done, see dependencies.
