Last modified: 2012-11-13 18:12:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43261, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41261 - Hard coded paths in PremadeMediawikiExtensionGroups::createMessageGroup() reduce flexibility
Hard coded paths in PremadeMediawikiExtensionGroups::createMessageGroup() red...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Niklas Laxström
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-21 22:22 UTC by Siebrand Mazeland
Modified: 2012-11-13 18:12 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2012-10-21 22:22:57 UTC
This is a regression.

This class is also used for MediaWiki extensions by Wikia, and because of the below code, this cannot be done at the moment without subclassing, which is a bit overdone.

https://gerrit.wikimedia.org/r/#/c/28812/3/ffs/MediaWikiExtensions.php lines 100-101:

$conf['FILES']['sourcePattern'] = "%GROUPROOT%/mediawiki-extensions/extensions/{$info['file']}";
$conf['FILES']['targetPattern'] = "mediawiki-extensions/extensions/{$info['file']}";

Current init code is below. Something similar should remain possible:

$wgHooks['TranslatePostInitGroups'][] = array( 'setupWikia' );
function setupWikia( &$cc, &$deps ) {
	global $wgTranslateGroupRoot, $GROUPS;

	$def = "$GROUPS/Wikia/extensions.txt";
	$path = "$wgTranslateGroupRoot/wikia/";

	$foo = new PremadeMediawikiExtensionGroups( $def, $path );
	$foo->setNamespace( NS_WIKIA );
	$foo->setGroupPrefix( 'wikia-' );
	$foo->setUseConfigure( false );
	$foo->addAll();

	$deps[] = new FileDependency( $def );
	return true;
}

For triagers: This would not affect Wikimedia wikis.
Comment 1 Niklas Laxström 2012-10-22 11:36:42 UTC
https://gerrit.wikimedia.org/r/29289

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links